From owner-freebsd-stable@FreeBSD.ORG  Thu Jan 17 07:56:59 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 9FF16EF
 for <freebsd-stable@freebsd.org>; Thu, 17 Jan 2013 07:56:59 +0000 (UTC)
 (envelope-from kpaasial@gmail.com)
Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com
 [209.85.223.177]) by mx1.freebsd.org (Postfix) with ESMTP id 6CC4DA87
 for <freebsd-stable@freebsd.org>; Thu, 17 Jan 2013 07:56:59 +0000 (UTC)
Received: by mail-ie0-f177.google.com with SMTP id k13so4143166iea.8
 for <freebsd-stable@freebsd.org>; Wed, 16 Jan 2013 23:56:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=l2g1LYgNTyLn7uMpXZKikye4ag5k9QmHDEG98l69Q/Y=;
 b=eDRVEUNnaNTJMYiGyjlw6874YjeJqWjiy0QhSWpYtecUj1lnhQKYSOPAJ0ka0myDm5
 WclkEYCO4Et1G9jdZQUGZxun2tSIukYPrR0QmCZAPZ8Llr0UEa0FbehkoWzhmAKRW/LS
 bXxAZz4HgvA3L0fj1f6D77q1qitMzYdfnJdeQS4AHRj4vvZ0hq9L+Ks0PO7/oWszLIuA
 LVJOKg0wwAc5CTqawROincyTr+QZ9J+mRrBPJDv5md86cD/9lt8d9z9wm37/UmfA2Gpy
 TgC+OnsUsiOveV6UDXTHAyyVFwZyqt+lG8g6xnbBUGFLPjxO5xSlLcHH1UBTDV2MN219
 Wm9g==
MIME-Version: 1.0
X-Received: by 10.50.179.99 with SMTP id df3mr2955384igc.94.1358409418791;
 Wed, 16 Jan 2013 23:56:58 -0800 (PST)
Received: by 10.64.143.138 with HTTP; Wed, 16 Jan 2013 23:56:58 -0800 (PST)
In-Reply-To: <20130117073301.GA39402@anubis.morrow.me.uk>
References: <CA+7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com>
 <50F6D20A.6070306@FreeBSD.org>
 <CA+7WWSfE1bAr7GriRGAKBVpkiNE+tn-+d0cO3vpNPY-SWxfghg@mail.gmail.com>
 <20130117001116.GD29437@lor.one-eyed-alien.net>
 <CA+7WWSfo0jX_tJEZ8YyzLSnnfaUZ0+sFYtVHhh8d=x2dYa+VXg@mail.gmail.com>
 <20130117073301.GA39402@anubis.morrow.me.uk>
Date: Thu, 17 Jan 2013 09:56:58 +0200
Message-ID: <CA+7WWSde5Dv=5hFmOv2j5_RucrUQL1_2sL9Rdu0WEXQA-v129A@mail.gmail.com>
Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9
From: Kimmo Paasiala <kpaasial@gmail.com>
To: Ben Morrow <ben@morrow.me.uk>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-stable@freebsd.org
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2013 07:56:59 -0000

On Thu, Jan 17, 2013 at 9:33 AM, Ben Morrow <ben@morrow.me.uk> wrote:
> Quoth Kimmo Paasiala <kpaasial@gmail.com>:
>>
>> Doesn't the change to strnvis() break the ABI on FreeBSD 9.X? I
>> thought you could always compile a binary on an earlier version of
>> FreeBSD 9.X and trust it to work without recompiling on any later
>> minor version of the same major version line.
>
> No, it doesn't. No existing prototypes are changed, there are just a
> number of *nvis* functions added to complement the existing ones that
> didn't have length arguments. The only problem is that the port assumes
> that if a system has strnvis, it has a prototype matching OpenBSD's,
> which the new one doesn't.
>
> Ben
>

Aah yes, thanks for clarification. I'll submit a PR about the port then.

-Kimmo