From owner-freebsd-current@freebsd.org Fri May 14 15:29:16 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D04ED64C036 for ; Fri, 14 May 2021 15:29:16 +0000 (UTC) (envelope-from hlh@restart.be) Received: from tignes.restart.be (tignes.restart.be [37.187.123.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tignes.restart.be", Issuer "CA master" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FhXWH4krbz4RS4 for ; Fri, 14 May 2021 15:29:15 +0000 (UTC) (envelope-from hlh@restart.be) X-Comment: SPF check N/A for local connections - client-ip=192.168.25.127; helo=restart.be; envelope-from=hlh@restart.be; receiver= DKIM-Filter: OpenDKIM Filter v2.10.3 tignes.restart.be 4FhXW71cG5z3M Received: from restart.be (norquay.tunnel.bel [192.168.25.127]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.restart.be", Issuer "CA master" (verified OK)) by tignes.restart.be (Postfix) with ESMTPS id 4FhXW71cG5z3M; Fri, 14 May 2021 17:29:04 +0200 (CEST) Received: from morzine.restart.bel (morzine.restart.be [IPv6:2001:41d0:a:f40b:1:1:0:1]) (authenticated bits=0) by restart.be (8.16.1/8.16.1) with ESMTPSA id 14EFT3YH020171 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=OK); Fri, 14 May 2021 17:29:03 +0200 (CEST) (envelope-from hlh@restart.be) X-Authentication-Warning: norquay.restart.bel: Host morzine.restart.be [IPv6:2001:41d0:a:f40b:1:1:0:1] claimed to be morzine.restart.bel Subject: Re: CURRENT crashes at early boot on Lenovo T540p: rtsx to blame - 13.0-RELEASE crashes same way! To: Marc Veldman , gljennjohn@gmail.com Cc: freebsd-current@freebsd.org References: <8d2be5f2-4144-082e-4237-0dac0c4b37e6@restart.be> <6798878a-c499-d78d-e96d-d744513cb80d@restart.be> <1de588e2-20cb-3206-3aea-f3f88f577675@restart.be> <67f0874a-6a05-67f1-3f2b-c4b3dc67fa11@FreeBSD.org> <83b823bf-c6c2-2f6a-b5dd-2e91b4d1931e@restart.be> <2c208bbc-5adc-2327-4717-a5e7c8d64b4b@FreeBSD.org> <9a15daa7-2b17-e257-d4d1-850c632a9db8@restart.be> <417a97b9-2c40-310c-c445-b193c493b880@FreeBSD.org> <7eb763ce-0bbf-9baf-2ede-968ee25cff2e@restart.be> <0CA59364-6802-4733-962A-3EEB00B43AFE@bumblingdork.com> <20210514144830.6b19de85@ernst.home> <51290711-0DC5-45DD-B2DB-4C2D98667DC7@bumblingdork.com> From: Henri Hennebert Message-ID: Date: Fri, 14 May 2021 17:29:03 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <51290711-0DC5-45DD-B2DB-4C2D98667DC7@bumblingdork.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FhXWH4krbz4RS4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:37.187.123.11/32:c]; HAS_XAW(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[restart.be:+]; DMARC_POLICY_ALLOW(-0.50)[restart.be,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SUBJECT_ENDS_EXCLAIM(0.00)[]; FREEMAIL_TO(0.00)[bumblingdork.com,gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[37.187.123.11:from]; ASN(0.00)[asn:16276, ipnet:37.187.0.0/16, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[restart.be:s=tignes]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[37.187.123.11:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 15:29:16 -0000 On 5/14/21 5:05 PM, Marc Veldman wrote: > >> On 14 May 2021, at 16:48, Gary Jennejohn wrote: >> >> On Fri, 14 May 2021 16:21:05 +0200 >> Marc Veldman wrote: >> >>>> On 14 May 2021, at 10:22, Henri Hennebert wrote: >>>> >>>> >>>> Please test the 2.0h version from GitHub. >>>> >>> >>> On my Lenovo P50s: >>> >>> Cold boot with card not inserted: OK >>> Insert card after boot, no crash, but the message >>> seems weird: >>> >>> May 14 16:01:27 supernovo kernel: rtsx0: Interrupt card inserted/removed >>> May 14 16:01:27 supernovo kernel: rtsx0: Card absent >>> May 14 16:01:27 supernovo kernel: mmc0: detached >>> >>> Cold boot with card inserted: OK >>> Remove card after boot, no crash, but the message >>> seems weird: >>> >>> May 14 16:06:08 supernovo kernel: rtsx0: Interrupt card inserted/removed >>> May 14 16:06:08 supernovo kernel: rtsx0: Card present >>> May 14 16:06:08 supernovo kernel: mmc0: on rtsx0 >>> >>> I have the inversion flag turned on /boot/loader.conf >>> >>> dev.rtsx.0.inversion=1 >>> dev.rtsx.0.debug=1 >>> >> >> This is weird because the man page states that the inversion flag is >> required with the P50. >> >> BTW Henri, if you're reading this, there's a bug in exactly this part >> of the man page: sovled rather than solved Thank you for the hint - will be corrected in the next push. >> >> But, the trace output indicates that you do not need the inversion flag. >> >> Maybe your P50 (may be a later model than the P50s tested during driver >> development) does not have the problem. > > > I removed the flag, and it works now.Thanks! > What is it in the trace that indicated that the inversion flag is not needed? In Bug 255130 they ask me to automate the inversion. I do it for the P50s and T470p following informations from Bug 204521. But strangely it is not applicable to this particular P50s. So, as indicated in my previous mail, it must be nullify with dev.rtsx.0.inversion=0. To investigate this last problem can you send kenv | grep smbios.system and dmesg|grep rtsx for the setup that work for you. Thanks Henri > > Best Regards, > > Marc Veldman > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >