From owner-freebsd-current@freebsd.org Fri Feb 24 14:50:51 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C58ECEB871 for ; Fri, 24 Feb 2017 14:50:51 +0000 (UTC) (envelope-from jiashiun@gmail.com) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42FE71015; Fri, 24 Feb 2017 14:50:51 +0000 (UTC) (envelope-from jiashiun@gmail.com) Received: by mail-qk0-x230.google.com with SMTP id u188so20130667qkc.2; Fri, 24 Feb 2017 06:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DHjowMxAN1FqCb8RuwRIkGw7Y8oKYuNbSqhPuGDXxWA=; b=MT3bNvKoOi9ijIyUv4Ja3w9nqljLyesd2HTDt2SMX+F22tloncz5501V02oso3/AAO d0fvTOzBtYaom5mxZ4korXwzFocu66JrO5OiJRZ0T9kPn5NVaa6v8u+sDXwPFvz6gEOK ym3HyylE3gcjZIkfgNdnFYWC/ScwRF89vHca121STkDqazrzG1iJuSv+eHK2NrSgZj5p c9JWjNHzLgvzBbmERWjoXAK1JFXtj+mBVcaeIl0DevEozg9PQ4nmm2U+gHMhMybOQWTW LEB3wd1f6GiC+/M+xlwJ/ZPjgSjKSMV6Du6AMifSYAJVml5OPfTrzKwptYS1mdFkxAEo DjhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DHjowMxAN1FqCb8RuwRIkGw7Y8oKYuNbSqhPuGDXxWA=; b=CCgbpe/Z1IbRtcvnY9PoNpc+1CAs/YtzE4yFsiwAKpdjxeUb3xEewoqnXTPoHs7oNo 2rJCNPNKq6njQZQQ+NV01/ii+ED8mMe6QNdgIEY93BiI9piWJ4vdxbhQfwT8gF/B44S1 V2uxDIzL5cI9CF8M6X40VzoKmEELPhvdWEu5cDXLSZFh+RGCAhSV7nhqcM3SlWJjzIPv P/OgvbBfcNXIDo/W3y/U+F5JZjELRegTuXNYytLA2giqN/7YeOVjLo8N/iXvJ680O7An oPqC728F/5DbRRT9GB0LUq6OtOeYngm+9E3TK0Ok20/3i0pjHTs6Z755m6jwvInubPJ+ tMxw== X-Gm-Message-State: AMke39kbrhkO4DbjWqa6KZZLsl4mXUd74v7X8qbM0x94oSRM1FCq8lDcGFyoYBVz0wGnSV/yG8sY81nAxpFJgA== X-Received: by 10.55.20.131 with SMTP id 3mr3237103qku.320.1487947850162; Fri, 24 Feb 2017 06:50:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.104.8 with HTTP; Fri, 24 Feb 2017 06:50:19 -0800 (PST) In-Reply-To: References: <20170113120534.GC2349@kib.kiev.ua> <20170223100829.GR2092@kib.kiev.ua> <2204246.QKzIRnxiUQ@ralph.baldwin.cx> <20170224114541.GU2092@kib.kiev.ua> From: Jia-Shiun Li Date: Fri, 24 Feb 2017 22:50:19 +0800 Message-ID: Subject: Re: TSC as timecounter makes system lag To: Konstantin Belousov Cc: John Baldwin , freebsd-current , Konstantin Belousov Content-Type: multipart/mixed; boundary=001a1144d05c0e02bb054947db7c X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:50:51 -0000 --001a1144d05c0e02bb054947db7c Content-Type: text/plain; charset=UTF-8 On Fri, Feb 24, 2017 at 9:32 PM, Jia-Shiun Li wrote: > On Fri, Feb 24, 2017 at 7:45 PM, Konstantin Belousov > wrote: > >> On Fri, Feb 24, 2017 at 12:15:26PM +0800, Jia-Shiun Li wrote: >> > Tested working on E7400 against r313909. And changing timecounter >> from/to >> > TSC >> > correctly enables/disables C2. >> > >> > The latter part cpu_disable_c2_sleep++ is not needed. When >> > init_TSC_tc() got called timecounter is not yet tsc_timecounter. >> > inittimecounter() later will do the work calling tc_windup(). >> > >> >> You mean, just this >> - if (cpu_deepest_sleep >= 2 && cpu_vendor_id == CPU_VENDOR_INTEL && >> + if (cpu_vendor_id == CPU_VENDOR_INTEL && >> is enough to fix the issue ? If yes, we can remove the cpu_deepest_sleep >> variable. This is John' observation, I think he would prefer to prepare >> the patch. >> > > Correct. That's enough. > > Since that's simple enough... patch attached. Tested against r313909 too. -Jia-Shiun. --001a1144d05c0e02bb054947db7c Content-Type: application/octet-stream; name="fix-tsc-timecounter.patch" Content-Disposition: attachment; filename="fix-tsc-timecounter.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_izjwv51t0 SW5kZXg6IHN5cy9kZXYvYWNwaWNhL2FjcGlfY3B1LmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2Rldi9h Y3BpY2EvYWNwaV9jcHUuYwkocmV2aXNpb24gMzEzOTA5KQorKysgc3lzL2Rldi9hY3BpY2EvYWNw aV9jcHUuYwkod29ya2luZyBjb3B5KQpAQCAtNzAzLDcgKzcwMyw2IEBACiAgICAgc2MtPmNwdV9u b25fYzIgPSBzYy0+Y3B1X2N4X2NvdW50OwogICAgIHNjLT5jcHVfbm9uX2MzID0gc2MtPmNwdV9j eF9jb3VudDsKICAgICBzYy0+Y3B1X2N4X2NvdW50Kys7Ci0gICAgY3B1X2RlZXBlc3Rfc2xlZXAg PSAxOwogCiAgICAgLyogCiAgICAgICogVGhlIHNwZWMgc2F5cyBQX0JMSyBtdXN0IGJlIDYgYnl0 ZXMgbG9uZy4gIEhvd2V2ZXIsIHNvbWUgc3lzdGVtcwpAQCAtNzI5LDcgKzcyOCw2IEBACiAJICAg IGN4X3B0cisrOwogCSAgICBzYy0+Y3B1X25vbl9jMyA9IHNjLT5jcHVfY3hfY291bnQ7CiAJICAg IHNjLT5jcHVfY3hfY291bnQrKzsKLQkgICAgY3B1X2RlZXBlc3Rfc2xlZXAgPSAyOwogCX0KICAg ICB9CiAgICAgaWYgKHNjLT5jcHVfcF9ibGtfbGVuIDwgNikKQEAgLTc0Niw3ICs3NDQsNiBAQAog CSAgICBjeF9wdHItPnRyYW5zX2xhdCA9IEFjcGlHYmxfRkFEVC5DM0xhdGVuY3k7CiAJICAgIGN4 X3B0cisrOwogCSAgICBzYy0+Y3B1X2N4X2NvdW50Kys7Ci0JICAgIGNwdV9kZWVwZXN0X3NsZWVw ID0gMzsKIAl9CiAgICAgfQogfQpAQCAtODMxLDcgKzgyOCw2IEBACiAgICAgY3hfcHRyLT50eXBl ID0gQUNQSV9TVEFURV9DMDsKICAgICBjeF9wdHIrKzsKICAgICBzYy0+Y3B1X2N4X2NvdW50Kys7 Ci0gICAgY3B1X2RlZXBlc3Rfc2xlZXAgPSAxOwogCiAgICAgLyogU2V0IHVwIGFsbCB2YWxpZCBz dGF0ZXMuICovCiAgICAgZm9yIChpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKQEAgLTg4NCw4ICs4 ODAsNiBAQAogCSAgICBjb250aW51ZTsKIAljYXNlIEFDUElfU1RBVEVfQzI6CiAJICAgIHNjLT5j cHVfbm9uX2MzID0gc2MtPmNwdV9jeF9jb3VudDsKLQkgICAgaWYgKGNwdV9kZWVwZXN0X3NsZWVw IDwgMikKLQkJICAgIGNwdV9kZWVwZXN0X3NsZWVwID0gMjsKIAkgICAgYnJlYWs7CiAJY2FzZSBB Q1BJX1NUQVRFX0MzOgogCWRlZmF1bHQ6CkBAIC04OTQsOCArODg4LDcgQEAKIAkJCQkgImFjcGlf Y3B1JWQ6IEMzWyVkXSBub3QgYXZhaWxhYmxlLlxuIiwKIAkJCQkgZGV2aWNlX2dldF91bml0KHNj LT5jcHVfZGV2KSwgaSkpOwogCQljb250aW51ZTsKLQkgICAgfSBlbHNlCi0JCWNwdV9kZWVwZXN0 X3NsZWVwID0gMzsKKwkgICAgfQogCSAgICBicmVhazsKIAl9CiAKSW5kZXg6IHN5cy9rZXJuL2tl cm5fY2xvY2tzb3VyY2UuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMva2Vybi9rZXJuX2Nsb2Nrc291cmNl LmMJKHJldmlzaW9uIDMxMzkwOSkKKysrIHN5cy9rZXJuL2tlcm5fY2xvY2tzb3VyY2UuYwkod29y a2luZyBjb3B5KQpAQCAtNTQsNyArNTQsNiBAQAogI2luY2x1ZGUgPG1hY2hpbmUvY3B1Lmg+CiAj aW5jbHVkZSA8bWFjaGluZS9zbXAuaD4KIAotaW50CQkJY3B1X2RlZXBlc3Rfc2xlZXAgPSAwOwkv KiBEZWVwZXN0IEN4IHN0YXRlIGF2YWlsYWJsZS4gKi8KIGludAkJCWNwdV9kaXNhYmxlX2MyX3Ns ZWVwID0gMDsgLyogVGltZXIgZGllcyBpbiBDMi4gKi8KIGludAkJCWNwdV9kaXNhYmxlX2MzX3Ns ZWVwID0gMDsgLyogVGltZXIgZGllcyBpbiBDMy4gKi8KIApJbmRleDogc3lzL3N5cy9zeXN0bS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHN5cy9zeXMvc3lzdG0uaAkocmV2aXNpb24gMzEzOTA5KQorKysgc3lz L3N5cy9zeXN0bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMjEsNyArMzIxLDYgQEAKIHZvaWQJY3B1 X2FjdGl2ZWNsb2NrKHZvaWQpOwogdm9pZAljcHVfbmV3X2NhbGxvdXQoaW50IGNwdSwgc2JpbnRp bWVfdCBidCwgc2JpbnRpbWVfdCBidF9vcHQpOwogdm9pZAljcHVfZXRfZnJlcXVlbmN5KHN0cnVj dCBldmVudHRpbWVyICpldCwgdWludDY0X3QgbmV3ZnJlcSk7Ci1leHRlcm4gaW50CWNwdV9kZWVw ZXN0X3NsZWVwOwogZXh0ZXJuIGludAljcHVfZGlzYWJsZV9jMl9zbGVlcDsKIGV4dGVybiBpbnQJ Y3B1X2Rpc2FibGVfYzNfc2xlZXA7CiAKSW5kZXg6IHN5cy94ODYveDg2L3RzYy5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHN5cy94ODYveDg2L3RzYy5jCShyZXZpc2lvbiAzMTM5MDkpCisrKyBzeXMveDg2L3g4 Ni90c2MuYwkod29ya2luZyBjb3B5KQpAQCAtNTQyLDcgKzU0Miw3IEBACiAJICogcmVzdWx0IGlu Y29ycmVjdCBydW50aW1lcyBmb3Iga2VybmVsIGlkbGUgdGhyZWFkcyAoYnV0IG5vdAogCSAqIGZv ciBhbnkgbm9uLWlkbGUgdGhyZWFkcykuCiAJICovCi0JaWYgKGNwdV9kZWVwZXN0X3NsZWVwID49 IDIgJiYgY3B1X3ZlbmRvcl9pZCA9PSBDUFVfVkVORE9SX0lOVEVMICYmCisJaWYgKGNwdV92ZW5k b3JfaWQgPT0gQ1BVX1ZFTkRPUl9JTlRFTCAmJgogCSAgICAoYW1kX3BtaW5mbyAmIEFNRFBNX1RT Q19JTlZBUklBTlQpID09IDApIHsKIAkJdHNjX3RpbWVjb3VudGVyLnRjX2ZsYWdzIHw9IFRDX0ZM QUdTX0MyU1RPUDsKIAkJaWYgKGJvb3R2ZXJib3NlKQo= --001a1144d05c0e02bb054947db7c--