From nobody Fri Jun 3 23:03:13 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C46601BEFB2F; Fri, 3 Jun 2022 23:03:24 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LFJMb1Ng5z58Ys; Fri, 3 Jun 2022 23:03:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x636.google.com with SMTP id w3so7758381plp.13; Fri, 03 Jun 2022 16:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5wfTNb1vuBi901R6RakQ3/p2zCo6w4H5cdsIlIyaxD8=; b=NcXgP1laoN9+Sn2yqLQu/9DM3eUmi2pyWF2P9MfNpjevonIhQi9DeSCmlktOn0z5w9 ip6YI7aQVMiruFaPuN+qlOYbFIzxnkEnQvZOi/ggoBLwPp6anrbWDM6CJkq86lwXT0Yt eNXFIMYFktgSGxiBeyIujBN/SU/wy/GUDW3TT8OuW9HOD1KVsFymtAYLQpqWlSwuoE89 3dtjKkwDCzrK4zBWC8aRwH5d8rJ/EwosTvESSdVJk+bsNid6AS6hJxI8xlXontKwRVHB Zk8XAFdfQCdwkJPaXrASKkqbmjPoST0fIMpOQRs6tDIAlNOCgmG78AT58hjr/XcotRem CwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5wfTNb1vuBi901R6RakQ3/p2zCo6w4H5cdsIlIyaxD8=; b=Z1IOlHppSsdo9TlzTO7JgmcSrnjHofw+ST4eNGkgrXJ9PBfvbvsWyv4yZF4NpcLvFg AtOHuMeYQltWjJyVoJ6kWt963QhKn6N8X3IP3mbwkPHwTlc5IgZETiR1+tSYVlkVAE5Q S5F5tTOw7UeoJT+KaJurdQNX+4zsBpxwpmxJvClLw5YwmYC09mzwnfQoooCQTQlY8BXi WENFx7quKzcvi3YLSKBPfwg3C/Z3+WRE6Aj7fYX99bHaRuPAs4pLWQjh34kuWNn7ANys 96UCUV695tsmwilmsQqW3toNuJflAYN7AJ6J9MSNmrY+AtNK5rfzADq6vZNKVM7S7DU9 cPDA== X-Gm-Message-State: AOAM53166I43REv2PCm4O2cE/IMlvF6bUiu8m9PR4amBUV+6bs+hFaBG 3ogCrM6+dGFMEQ4PFhZ5dUl5uO8PQo4= X-Google-Smtp-Source: ABdhPJznZgNWwCxU7D3pvPkx/1LL0ZUVPBrEMy2OHrFdpyAiMZrWO0kNBtdERd3dd0YQRYBD0eUFGg== X-Received: by 2002:a17:902:7886:b0:167:5c8c:4d3e with SMTP id q6-20020a170902788600b001675c8c4d3emr1341362pll.74.1654297396589; Fri, 03 Jun 2022 16:03:16 -0700 (PDT) Received: from ?IPV6:2403:5807:1b:1:6c9e:b489:476f:91c0? (2403-5807-1b-1-6c9e-b489-476f-91c0.ip6.aussiebb.net. [2403:5807:1b:1:6c9e:b489:476f:91c0]) by smtp.gmail.com with ESMTPSA id v9-20020aa78509000000b00518285976cdsm5947485pfn.9.2022.06.03.16.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 16:03:16 -0700 (PDT) Message-ID: <4c37b6f9-d1bc-55f3-bcb3-c423883f1516@FreeBSD.org> Date: Sat, 4 Jun 2022 09:03:13 +1000 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Thunderbird/103.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: git: a37e0e6de652 - main - pf: fix more syncookie memory leaks Content-Language: en-US To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206021818.252IIAdK087215@gitrepo.freebsd.org> <3C8AD404-31EC-49C6-B9D2-2F8888E22C7D@FreeBSD.org> From: Kubilay Kocak In-Reply-To: <3C8AD404-31EC-49C6-B9D2-2F8888E22C7D@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4LFJMb1Ng5z58Ys X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=NcXgP1la; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.79)[-0.793]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::636:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 3/06/2022 3:45 pm, Kristof Provost wrote: > > > On 3 Jun 2022, at 3:36, Kubilay Kocak wrote: >> On 3/06/2022 4:18 am, Kristof Provost wrote: >>> The branch main has been updated by kp: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=a37e0e6de6527a7eaddea8e28f5e4b3427fba1a4 >>> >>> commit a37e0e6de6527a7eaddea8e28f5e4b3427fba1a4 >>> Author: Franco Fichtner >>> AuthorDate: 2022-06-02 16:27:43 +0000 >>> Commit: Kristof Provost >>> CommitDate: 2022-06-02 18:17:25 +0000 >>> >>> pf: fix more syncookie memory leaks >>> Allocate memory for packed nvlists in M_NVLIST, as nvlist_pack() does >>> this as well, and we use the same variable interchangable with the >>> memory we allocate. When we free it we can end up freeing from the wrong >>> zone, leaking memory. >>> Reviewed by: kp >>> Differential Revision: https://reviews.freebsd.org/D35385 >> >> Hi Kristof, >> >> Are stable{13,12} affected or only introduced in main? >> > They are. This should be MFC’d, but I forgot to tag it. It’s already on my todo list though. > > Kristof Danke!