Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Jun 2012 17:12:49 +0100
From:      Matthew Seaman <m.seaman@infracaninophile.co.uk>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        ports@freebsd.org
Subject:   Re: ports need a uniq identifier, do you have any suggestion?
Message-ID:  <4FD61901.3010503@infracaninophile.co.uk>
In-Reply-To: <20120611160545.GC60433@ithaqua.etoilebsd.net>
References:  <20120611043001.GO60433@ithaqua.etoilebsd.net> <4FD591DF.3060808@infracaninophile.co.uk> <20120611103221.GU60433@ithaqua.etoilebsd.net> <4FD5D7B8.9080504@infracaninophile.co.uk> <20120611115529.GV60433@ithaqua.etoilebsd.net> <4FD5EFE1.30200@infracaninophile.co.uk> <20120611153614.GA60433@ithaqua.etoilebsd.net> <20120611153704.GB60433@ithaqua.etoilebsd.net> <4FD6136A.60704@infracaninophile.co.uk> <20120611160545.GC60433@ithaqua.etoilebsd.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig01E6E61A30564A671BFE1F32
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 11/06/2012 17:05, Baptiste Daroussin wrote:
> On Mon, Jun 11, 2012 at 04:48:58PM +0100, Matthew Seaman wrote:
>> On 11/06/2012 16:37, Baptiste Daroussin wrote:
>>>> This patch does the trick, I'm now running a script with that patch =
on to
>>>>> discovers all the uniquename names which are not really uniq
>>>>>
>>>>> regards,
>>>>> Bapt
>>>
>>> Here is the patch :) http://people.freebsd.org/~bapt/realuniq.diff
>>
>> Aren't you going to initialise PKGUNIQUENAMESUFFIX anywhere?

> No need except ports willing to have a custom PKGNAMEPREFIX but still w=
anted to
> have a custom prefix anyway.
>=20
> like=20
> PKGNAMEPREFIX=3D	${PYTHON_PKGNAMEPREFIX}
> PKGUNIQUEPREFIX=3D	py-
>=20
> which is not mandatory but can help avoiding UNIQUENAME collision

Not PREFIX --- SUFFIX.  You have:

UNIQUENAME?=3D	${PKGUNIQUENAMEPREFIX}${PORTNAME}${PKGUNIQUENAMESUFFIX}
                                                 ^^^^^^^^^^^^^^^^^^^^^^

or is this part of some cunning plan to do with sub-ports?

	Cheers,

	Matthew

--=20
Dr Matthew J Seaman MA, D.Phil.                   7 Priory Courtyard
                                                  Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey     Ramsgate
JID: matthew@infracaninophile.co.uk               Kent, CT11 9PW




--------------enig01E6E61A30564A671BFE1F32
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/WGQEACgkQ8Mjk52CukIyrrgCffIxSXZfHkjN9z3Car/nGTLcM
tKUAn1fbjqCvKeilzj0cOD5oM5gMnBIa
=Kux+
-----END PGP SIGNATURE-----

--------------enig01E6E61A30564A671BFE1F32--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FD61901.3010503>