From owner-freebsd-bugs Wed Sep 19 6: 0: 8 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id C2CD737B415 for ; Wed, 19 Sep 2001 06:00:05 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f8JD05K61656; Wed, 19 Sep 2001 06:00:05 -0700 (PDT) (envelope-from gnats) Date: Wed, 19 Sep 2001 06:00:05 -0700 (PDT) Message-Id: <200109191300.f8JD05K61656@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Ruslan Ermilov Subject: Re: bin/30641: Patch for games/grdc Reply-To: Ruslan Ermilov Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/30641; it has been noted by GNATS. From: Ruslan Ermilov To: Andrey Simonenko Cc: bug-followup@FreeBSD.org Subject: Re: bin/30641: Patch for games/grdc Date: Wed, 19 Sep 2001 15:58:08 +0300 On Tue, Sep 18, 2001 at 11:39:12AM +0300, Andrey Simonenko wrote: > > grdc(8) outputs big digital clock. Color of digits is red, if grdc(8) > is used on b/w display, then it is hard to see something. > > This patch adds new flag to grdc(8): -b, which changes color of digits > to b/w. Also arguments checking is improved. > Use the right (B/W) terminal type such as cons25-m. > In this patch type of "sigtermed" variable is changed from "int" to > "voilatile sig_atomic_t", because "sigtermed" variable is changed in signal > handler. > This looks OK though a bit superflows in this case. :-) Also, is sig_atomic_t guaranteed to be a superset of int? (I'm mostly concerned about the portability issues here, I know that in FreeBSD sig_atomic_t is ether int or long.) Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message