From owner-p4-projects@FreeBSD.ORG  Tue Jun  8 05:46:40 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E13CC16A4EA; Tue,  8 Jun 2004 05:46:39 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 99E9D16A4D1
	for <perforce@freebsd.org>; Tue,  8 Jun 2004 05:46:39 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8F67D43D41
	for <perforce@freebsd.org>; Tue,  8 Jun 2004 05:46:39 +0000 (GMT)
	(envelope-from jmallett@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i585ka6X055792
	for <perforce@freebsd.org>; Tue, 8 Jun 2004 05:46:36 GMT
	(envelope-from jmallett@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i585kaa4055789
	for perforce@freebsd.org; Tue, 8 Jun 2004 05:46:36 GMT
	(envelope-from jmallett@freebsd.org)
Date: Tue, 8 Jun 2004 05:46:36 GMT
Message-Id: <200406080546.i585kaa4055789@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jmallett@freebsd.org using -f
From: Juli Mallett <jmallett@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 54399 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2004 05:46:41 -0000

http://perforce.freebsd.org/chv.cgi?CH=54399

Change 54399 by jmallett@jmallett_oingo on 2004/06/08 05:46:09

	Notes to self on lessons not to be learned from Alpha.

Affected files ...

.. //depot/projects/mips/sys/mips/mips/trap.c#19 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/trap.c#19 (text+ko) ====

@@ -117,9 +117,16 @@
 		return (tf);
 	case TrInt:
 		platform_trap_exit();
-		atomic_add_int(&curthread->td_intr_nesting_level, 1);
+#if 0
+		/*
+		 * It looks like these break interrupt preemption.
+		 */
+		critical_enter();
+#endif
 		platform_intr(tf);
-		atomic_subtract_int(&curthread->td_intr_nesting_level, 1);
+#if 0
+		critical_exit();
+#endif
 		if (curthread)
 			tf = curthread->td_frame;
 		return (tf);