From owner-freebsd-bugs@FreeBSD.ORG Tue Jan 13 10:41:10 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1F4A16A4CE for ; Tue, 13 Jan 2004 10:41:10 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAF2143D5D for ; Tue, 13 Jan 2004 10:40:12 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0DIeCFR004485 for ; Tue, 13 Jan 2004 10:40:12 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0DIeC79004484; Tue, 13 Jan 2004 10:40:12 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 13 Jan 2004 10:40:12 -0800 (PST) Resent-Message-Id: <200401131840.i0DIeC79004484@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Valentin A. Alekseev" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E5AB16A4CE for ; Tue, 13 Jan 2004 10:31:31 -0800 (PST) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id D32B143D55 for ; Tue, 13 Jan 2004 10:31:29 -0800 (PST) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i0DIVTdL056757 for ; Tue, 13 Jan 2004 10:31:29 -0800 (PST) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.10/8.12.10/Submit) id i0DIVTKI056756; Tue, 13 Jan 2004 10:31:29 -0800 (PST) (envelope-from nobody) Message-Id: <200401131831.i0DIVTKI056756@www.freebsd.org> Date: Tue, 13 Jan 2004 10:31:29 -0800 (PST) From: "Valentin A. Alekseev" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.0 Subject: misc/61322: bsd.dep.mk disallows shell generated flags in CFLAGS X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2004 18:41:10 -0000 >Number: 61322 >Category: misc >Synopsis: bsd.dep.mk disallows shell generated flags in CFLAGS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jan 13 10:40:12 PST 2004 >Closed-Date: >Last-Modified: >Originator: Valentin A. Alekseev >Release: FreeBSD 5.2-CURRENT >Organization: n/a >Environment: FreeBSD alpha.valabs.spb.ru 5.2-CURRENT FreeBSD 5.2-CURRENT #16: Mon Jan 12 00:44:36 MSK 2004 valeks@alpha.valabs.spb.ru:/usr/obj/usr/src-5-CURRENT/sys/ALPHA i386 >Description: bsd.dep.mk disallows usage of shell generated CFLAGS while calling to mkdep. So there is no portable way to, for e.g., specify place of libxml2 includes (xml2-config --cflags). >How-To-Repeat: Makefile: .. PROG= xgrep CFLAGS+= `xml2-config --cflags` .. Output of make depend: $ make depend rm -f .depend mkdep -f .depend -a xgrep.c xgrep.c:6:27: libxml/parser.h: No such file or directory xgrep.c:7:26: libxml/xpath.h: No such file or directory mkdep: compile failed >Fix: Here is a patch that blindly allows ones to use any shell generated vars in CFLAGS. Maybe it would be better to replace M`* with M`*-config and M*` with M--cflags`. --- src/share/mk/bsd.dep.mk.orig Tue Jan 13 20:34:30 2004 +++ src/share/mk/bsd.dep.mk Tue Jan 13 20:58:57 2004 @@ -116,18 +116,18 @@ rm -f ${DEPENDFILE} .if ${SRCS:M*.[cS]} != "" ${MKDEPCMD} -f ${DEPENDFILE} -a ${MKDEP} \ - ${CFLAGS:M-nostdinc*} ${CFLAGS:M-[BID]*} \ + ${CFLAGS:M-nostdinc*} ${CFLAGS:M-[BID]*} ${CFLAGS:M`*} ${CFLAGS:M*`}\ ${.ALLSRC:M*.[cS]} .endif .if ${SRCS:M*.cc} != "" || ${SRCS:M*.C} != "" || ${SRCS:M*.cpp} != "" || \ ${SRCS:M*.cxx} != "" ${MKDEPCMD} -f ${DEPENDFILE} -a ${MKDEP} \ - ${CXXFLAGS:M-nostdinc*} ${CXXFLAGS:M-[BID]*} \ + ${CXXFLAGS:M-nostdinc*} ${CXXFLAGS:M-[BID]*} ${CFLAGS:M`*} ${CFLAGS:M*`} \ ${.ALLSRC:M*.cc} ${.ALLSRC:M*.C} ${.ALLSRC:M*.cpp} ${.ALLSRC:M*.cxx} .endif .if ${SRCS:M*.m} != "" ${MKDEPCMD} -f ${DEPENDFILE} -a ${MKDEP} \ - ${OBJCFLAGS:M-nostdinc*} ${OBJCFLAGS:M-[BID]*} \ + ${OBJCFLAGS:M-nostdinc*} ${OBJCFLAGS:M-[BID]*} ${CFLAGS:M`*} ${CFLAGS:M*`} \ ${OBJCFLAGS:M-Wno-import*} \ ${.ALLSRC:M*.m} .endif >Release-Note: >Audit-Trail: >Unformatted: