From owner-svn-ports-all@freebsd.org Sat Apr 14 13:45:33 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4905FFA1A13 for ; Sat, 14 Apr 2018 13:45:33 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: from mail-qt0-f174.google.com (mail-qt0-f174.google.com [209.85.216.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DEDD8804FD for ; Sat, 14 Apr 2018 13:45:32 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: by mail-qt0-f174.google.com with SMTP id z23so10855515qti.5 for ; Sat, 14 Apr 2018 06:45:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+DMghxJeZLsKYAgRxZy30AdA+q6tLapcS0ah0t1rIvo=; b=qlrm1KoDEjFmu4+3q889gHY+oVNA1f/sHem5Tq6kBGZyWFN/XtdBMcWrGdTqpQG0ZG 9h7Sj3gbjay6a1zxq+Uva/Xvq7jaXEdaEikJtHK7IL49AcsNedSoIJFRuKvIefpYfv0a Ts3yNSGidYAE8HddJM8Qx3j0QIMVbo4Pt+x/fDkc7ERRCf2yuzDV+Zb3ePt2+YqKCqvK caB7r/2WTrftAP6yn0qdxbeaqqlqZmx91UH5EqkjE8ox/y4TevmEyuCJOessthw1svN+ UquQKCZu/4XdApgIXZAvvcwh6iwdI9sNtcRFMQkruW2NictI5UdyMlastP/WbArB1sIN yiGQ== X-Gm-Message-State: ALQs6tAm//p1Xi5RGTrU0joty5f9aSapMQLIQVC7H1C9c5lnGmeodz4C BO6fO0yHelIAThFu7fvbEzkZMg== X-Google-Smtp-Source: AIpwx497anfjChG367mUC/WJ2BD9scHfEHtgsqiwSdNxFT9Vk5EieOq0dKoneEVsgERnSjUGPSpLlg== X-Received: by 10.200.22.145 with SMTP id r17mr7625057qtj.190.1523713532040; Sat, 14 Apr 2018 06:45:32 -0700 (PDT) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-47-55-140-73.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.140.73]) by smtp.gmail.com with ESMTPSA id x31sm6812132qtc.55.2018.04.14.06.45.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Apr 2018 06:45:31 -0700 (PDT) From: Joseph Mingrone To: Sunpoet Po-Chuan Hsieh Cc: Matthias Fechner , Alexey Dokuchaev , Torsten Zuehlsdorff , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> <86o9inrzzk.fsf@phe.ftfl.ca> Date: Sat, 14 Apr 2018 10:45:29 -0300 In-Reply-To: (Sunpoet Po-Chuan Hsieh's message of "Sat, 14 Apr 2018 04:13:00 +0800") Message-ID: <864lkdlx52.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2018 13:45:33 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sunpoet Po-Chuan Hsieh writes: > On Fri, Apr 13, 2018 at 9:35 PM, Joseph Mingrone wrote: >> Matthias Fechner writes: >> > Dear sunpoet, >> > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: >> >> Log: >> >> Fix Gemfile for rubygem-default_value_for 3.1.0 update >> >> - Bump PORTREVISION for package change >> >> Modified: >> >> head/www/gitlab/Makefile >> >> head/www/gitlab/files/patch-Gemfile >> > I really enjoy your work and it is totally fine for me, if you upgrade= a >> > gem that you copy the old one and make sure that gitlab uses the old. >> > (like you did with r467106, thanks a lot for this!) >> > But please do not start to patch the Gemfile! >> > This will break gitlab. Have you tested gitlab with this modification? >> > (for sure not, I reported exactly that version of default_value_for >> > upstream and they rolled back the change as it broke gitlab, they broke >> > 3.0.4 and rolled back the modification with 3.0.5, now you changed >> > gitlab to use the version that for sure will not work!) >> > Please revert this modification and ask me (the maintainer) before you >> > start to modify the port I maintain. >> > Thanks a lot that you understand this. >> > Gru=C3=9F >> > Matthias >> I relate. Sunpoet, I also appreciate your work, but this type of >> breakage can be frustrating. We need to figure out a solution. > Hi, > As I replied before, I'll keep the Gemfile unchanged. > The rubygem ports will follow the version requirement in Gemfile. > In fact, I stored the Gemfiles of gitlab, mastodon and vagrant in a > specific directory. > When I update a rubygem port, I check the dependent ports to see if they > accepts the newer version. > Regards, > sunpoet Thank you. For the past while Gem updates have been smooth for net-im/mast= odon. J. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlrSBflfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 755FhxAApak/7Dt+tuYcsMQX5nIF9Y1iqoRH58FhU/48LwsFy04QdCvftRBTi8lV SxlaUZ8D3xGPh8h2QB/AjJuEM3SZ1VpIrM0h6KDfln2TBPmKBBmnP2mikDmgDX/a LYPiuiMFRLBnZUfZi3w8K7PrpaREb6wx4m8nK20Q90qTixZfe6jD91ynYvBNU1E6 PIpuAlChOXHtFkfMUw+d49ZVPZvjJSvAM88inyd5jbW9LlgNz61VVA/mQ666Z08E YoMqUHdzgGepCrr2Ya9QnGfJqPsm1UjduxYHri16FPMH+zM/1A3IO+0ksUbda8d2 wEWxesPkFnoc5AHTP6jcV6vDkaVQI8EoxOYxJ+3s2Ju+fvTztDXcVrYR4Qxq3VhQ JW8aDu81vfmmOn7MAnKT4pxg1Fa9H01iJ1K1oH0qYjLFR2qObr+6Mhr0vaKXcZuU DXS3hSfgryC2iaYTiagBtAd6Qk9bkCJidnTGeUItG3PEVwn2aWT+WjPVR+xTL4gV GJt37jSel5Jk65GO1HMVa2N6MEg1LvfRVDaR7hUGb+e2vyRtrWKrIiIl41SqQm8O UG3rwIYMa4U1jm+NW+E8f6ChDPnXR+K5meAiu2J0r63HOgAv/J0b0RO6fY6UXrK2 +GzwSjTlZnjyCVtOL0rf20+GAlxvLBBrXV8kcgo9CIRsiSxtlFU= =rVKs -----END PGP SIGNATURE----- --=-=-=--