From owner-p4-projects@FreeBSD.ORG  Wed Jan  2 19:37:59 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 996A316A41A; Wed,  2 Jan 2008 19:37:59 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5DA4816A418
	for <perforce@FreeBSD.org>; Wed,  2 Jan 2008 19:37:59 +0000 (UTC)
	(envelope-from swise@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 4CAF513C45B
	for <perforce@FreeBSD.org>; Wed,  2 Jan 2008 19:37:59 +0000 (UTC)
	(envelope-from swise@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m02Jbxkd024613
	for <perforce@FreeBSD.org>; Wed, 2 Jan 2008 19:37:59 GMT
	(envelope-from swise@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m02Jbxgs024579
	for perforce@freebsd.org; Wed, 2 Jan 2008 19:37:59 GMT
	(envelope-from swise@FreeBSD.org)
Date: Wed, 2 Jan 2008 19:37:59 GMT
Message-Id: <200801021937.m02Jbxgs024579@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	swise@FreeBSD.org using -f
From: Steve Wise <swise@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 132326 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jan 2008 19:37:59 -0000

http://perforce.freebsd.org/chv.cgi?CH=132326

Change 132326 by swise@swise:vic10:iwarp on 2008/01/02 19:37:06

	dumping regs can corrupt memory.
	
	bad pointer math causes the register dump buffer to be 
	overrun.

Affected files ...

.. //depot/projects/iwarp/sys/dev/cxgb/cxgb_main.c#7 edit

Differences ...

==== //depot/projects/iwarp/sys/dev/cxgb/cxgb_main.c#7 (text+ko) ====

@@ -2683,7 +2683,7 @@
 reg_block_dump(struct adapter *ap, uint8_t *buf, unsigned int start,
     unsigned int end)
 {
-	uint32_t *p = (uint32_t *)buf + start;
+	uint32_t *p = (uint32_t *)(buf + start);
 
 	for ( ; start <= end; start += sizeof(uint32_t))
 		*p++ = t3_read_reg(ap, start);