From owner-cvs-src@FreeBSD.ORG Thu Jan 12 12:26:30 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7EB216A41F; Thu, 12 Jan 2006 12:26:30 +0000 (GMT) (envelope-from harry@schmalzbauer.de) Received: from flb.schmalzbauer.de (flb.schmalzbauer.de [62.245.232.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA37E43D45; Thu, 12 Jan 2006 12:26:28 +0000 (GMT) (envelope-from harry@schmalzbauer.de) Received: from sam.flintsbach.schmalzbauer.de (sam.flintsbach.schmalzbauer.de [172.21.2.4]) by flb.schmalzbauer.de (8.13.4/8.13.4) with ESMTP id k0CCR7bo020496; Thu, 12 Jan 2006 13:27:08 +0100 (CET) (envelope-from harry@cale.flintsbach.schmalzbauer.de) Received: from cale.flintsbach.schmalzbauer.de (cale.flintsbach.schmalzbauer.de [172.21.1.252]) by sam.flintsbach.schmalzbauer.de (Postfix) with ESMTP id D1B06B62D; Thu, 12 Jan 2006 13:26:26 +0100 (CET) Received: from cale.flintsbach.schmalzbauer.de (localhost [127.0.0.1]) by cale.flintsbach.schmalzbauer.de (8.13.4/8.13.4) with ESMTP id k0CCQK3g008906; Thu, 12 Jan 2006 13:26:20 +0100 (CET) (envelope-from harry@cale.flintsbach.schmalzbauer.de) Received: from localhost (localhost [[UNIX: localhost]]) by cale.flintsbach.schmalzbauer.de (8.13.4/8.13.4/Submit) id k0CCQJgP008905; Thu, 12 Jan 2006 13:26:19 +0100 (CET) (envelope-from harry@cale.flintsbach.schmalzbauer.de) From: Harald Schmalzbauer To: cvs-src@freebsd.org Date: Thu, 12 Jan 2006 13:26:12 +0100 User-Agent: KMail/1.8.1 References: <200512280153.jBS1rEd6086940@repoman.freebsd.org> In-Reply-To: <200512280153.jBS1rEd6086940@repoman.freebsd.org> X-Birthday: Oct. 6th 1972 X-CelPhone: +49 (0) 173 9967781 X-Tel: +49 (0) 89 18947781 X-Country: Germany X-Address: Munich, 80686 X-OS: FreeBSD MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3129393.k1mnOZbaXg"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200601121326.19634@harrymail> Cc: src-committers@freebsd.org, Pawel Jakub Dawidek Subject: Re: cvs commit: src/sys/kern kern_malloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2006 12:26:31 -0000 --nextPart3129393.k1mnOZbaXg Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Am Mittwoch, 28. Dezember 2005 02:53 CEST schrieb Pawel Jakub Dawidek: > pjd 2005-12-28 01:53:13 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_malloc.c > Log: > In realloc(9), determine size of the original block based on > UMA_SLAB_MALLOC flag. > In some circumstances (I observed it when I was doing a lot of > reallocs) UMA_SLAB_MALLOC can be set even if us_keg !=3D NULL. > > If this is the case we have wonderful, silent data corruption, because > less data is copied to the newly allocated region than should be. > > I'm not sure when this bug was introduced, it could be there > undetected for years now, as we don't have a lot of realloc(9) consumers > and it was hard to reproduce it... > ...but what I know for sure, is that I don't want to know who > introduce the bug:) It took me two/three days to track it down (of > course most of the time I was looking for the bug in my own code). > > Revision Changes Path > 1.150 +1 -1 src/sys/kern/kern_malloc.c Thanks for your work, I'm using it in RELENG_6 from day one without any=20 impact, so perhaps it's safe to MFC? =2DHarry > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" --nextPart3129393.k1mnOZbaXg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBDxkrrBylq0S4AzzwRApzTAJ91KMYcPoTkUmbGMgPaehfzSgtmXgCfcshR dS52fxQOuhAuJOCdyxPf4Fc= =8y16 -----END PGP SIGNATURE----- --nextPart3129393.k1mnOZbaXg--