Date: Fri, 3 Apr 2020 09:40:37 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Fernando =?utf-8?Q?Apestegu=C3=ADa?= <fernape@freebsd.org> Cc: Mateusz Piotrowski <0mp@freebsd.org>, "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, tom@hur.st Subject: Re: svn commit: r530275 - in head/sysutils/checkrestart: . files Message-ID: <20200403074037.vwysv4oj2gdmnerb@aching.in.mat.cc> In-Reply-To: <CAGwOe2ZaVD-i1Nto%2BCSBL%2BxxzrmNptxMhNijSCrO5LVYgz5Grg@mail.gmail.com> References: <202004021151.032BpOMI028447@repo.freebsd.org> <b5e76d0b-b3cf-0c02-10fa-db607eab1df8@FreeBSD.org> <CAGwOe2ZaVD-i1Nto%2BCSBL%2BxxzrmNptxMhNijSCrO5LVYgz5Grg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nuhsv3zuna7xpshq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 02, 2020 at 07:56:16PM +0200, Fernando Apestegu=EDa wrote: > On Thu, Apr 2, 2020 at 2:00 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > > > Hi, > > > > On 4/2/20 1:51 PM, Fernando Apestegu=EDa wrote: > > > Author: fernape > > > Date: Thu Apr 2 11:51:24 2020 > > > New Revision: 530275 > > > URL: https://svnweb.freebsd.org/changeset/ports/530275 > > > > > > Log: > > > sysutils/checkrestart: Update to 0.5.0 > > ... > > > Added: head/sysutils/checkrestart/files/checkrestart.in > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/sysutils/checkrestart/files/checkrestart.in Thu Apr 2 11:5= 1:24 2020 (r530275) > > > @@ -0,0 +1,70 @@ > > > +#!/bin/sh > > > +# $FreeBSD$ > > > + > > > +if [ -r /etc/defaults/periodic.conf ]; then > > > + . /etc/defaults/periodic.conf > > > + source_periodic_confs > > > +fi > > > + > > > +: "${daily_checkrestart_enable:=3DNO}" > > > +: "${daily_checkrestart_weekdays:=3D1234567}" # Days of the week to = run, Monday=3D1 > > > +: "${daily_checkrestart_users:=3D}" # User names or IDs to= check > > > +: "${daily_checkrestart_jails:=3D}" # Jail names or IDs to= check > > > +: "${daily_checkrestart_procs:=3D}" # Process names or IDs= to check > > > + > > > +checkrestartcmd=3D/usr/local/bin/checkrestart > > > > This should probably utilize %%PREFIX%%. > > > > > + > > > +case "${daily_checkrestart_enable}" in > > > + [Yy][Ee][Ss]) > > Please use checkyesno from rc.subr(8) instead. >=20 > Hi Mateusz, >=20 > Thanks for the point. Would you have a look at > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245283? The > maintainer doesn't see appropriate this last suggestion. Feel free to > jump in. You know, thre reason we have committers and not a script that applies the patch and commits is so that we can change the submission to better fit our policies. You do not need the maintainer's approval to change that. See the penultimate paragraph here: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.h= tml --=20 Mathieu Arnold --nuhsv3zuna7xpshq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl6G6HBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgJVKg//YvoupwU3nxf1m/ZHU7QGAcuhz9ayFxEpXhhoiVaxm2XmfcrDqvwSiXPm CJSoliz3mM2EP5Ruo7nkXsw0skuleQjfkRzoKcUYMrjTN/Zqs6kiqukIM5RbViym OSDEIc9uEHyCDXrXnL9D+jyfl22n08jo2Lo4G1JEw0chrfcqZlMcNk001H2uSFiL DOXDsXgWE/q4yeG3/phpR1ZmJjPc+t4sBlcCOahwKKjBt1ojSEvCDux94fo5SeH9 MM5BUdDewuleTX9qiqLtu/yvC8paH5YDv6889t0hwj63oFvMvtrPEmuOJGLXM/eb 198N46PtlBPI66AvwmELKvbj4FVwrbtz1SkID+IJEeTr9Ud4MIa/lK2dtlTJojoV 8bK5KQ+Dg9PsI16yXiYsUQqox5dM6bvjyRjkCs1TmLQxxyuoEXxPMpRzvbRUGb7m pFSAMkEcdpbkf6x+O6B7SeR3kUHTsRJF0MwEJOcznxuoQoFMkrBcaEWVPfzdrJsx 5uRbGDvr67OBYy5tQs1v53z/8Yg0y5vag/QNucVDeHrmfR2hcZH7g9lZAVFL3f9L bHawFM1t/eNLymvYXoDa3qS0yK0tSdYKrt3ntvA9vB5KB8Gh/dsMkSR+Q7MMbsiG UUFhhSl2KDzt5tKlxN7udexQdHbsAWZJgIBv5V/XO3QS3Ghv3/o= =sOI+ -----END PGP SIGNATURE----- --nuhsv3zuna7xpshq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200403074037.vwysv4oj2gdmnerb>