From nobody Mon Nov 24 23:26:05 2025 X-Original-To: hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dFhlp3vHBz6J1x6 for ; Mon, 24 Nov 2025 23:26:14 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dFhln6pKMz3vQk for ; Mon, 24 Nov 2025 23:26:13 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (124-18-6-240.area1c.commufa.jp [124.18.6.240]) (authenticated bits=0) by www121.sakura.ne.jp (8.18.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 5AONQ5j0013270; Tue, 25 Nov 2025 08:26:07 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dec.sakura.ne.jp; s=s2405; t=1764026767; bh=lJD2HnWlAZo0UDG/K9ObuHlXHsGMcblXIi0jrAfj9t4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eJKWlj3sKFl200Y/tGqKzE3RjTEyeBZg7xbjZk/xwCNkWuJA++Mi4cL7Uuxq6kOah GysmgWZvDIvNSFGTne3mTAJbPs0WE0jCzUJ9dtdMaeMsjlC6S/PLjy3c2Mno1EsuWa js22uszKO4GreLB08ZeBdnjW3mwvcnXSpwFvvvhw= Date: Tue, 25 Nov 2025 08:26:05 +0900 From: Tomoaki AOKI To: Mark Linimon Cc: Warner Losh , Ankush Mondal , hackers@freebsd.org Subject: Re: [PATCH] df: correct BLOCKSIZE handling for -k to use 1K-blocks (290710) Message-Id: <20251125082605.0cb9ab55a2c71a415b575c41@dec.sakura.ne.jp> In-Reply-To: <1789299192.176069.1764023439861@privateemail.com> References: <1789299192.176069.1764023439861@privateemail.com> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dFhln6pKMz3vQk On Mon, 24 Nov 2025 16:30:39 -0600 (CST) Mark Linimon wrote: > > On 11/24/2025 10:03 AM CST Warner Losh wrote: > > Also, we generally don't do code reviews in hackers@. Your best bet is likely a github pull request. I'll keep my eyes open there. > > Then that's even more bad advice in the various Articles/wiki. > > I'll put it on the ever-increasing list ... > > mcl The best way for code review with FreeBSD is Phablicator for me. The accounts are managed by FreeBSD project (or FreeBSD foundation), unlike github. And works fine for me (with some difficulty, though, on opening review with adding files, but it can be overcome). -- Tomoaki AOKI