From owner-freebsd-current@FreeBSD.ORG  Wed Nov 16 18:07:16 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1F23A1065676;
	Wed, 16 Nov 2011 18:07:16 +0000 (UTC)
	(envelope-from delphij@delphij.net)
Received: from anubis.delphij.net (anubis.delphij.net
	[IPv6:2001:470:1:117::25])
	by mx1.freebsd.org (Postfix) with ESMTP id 030D68FC14;
	Wed, 16 Nov 2011 18:07:16 +0000 (UTC)
Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by anubis.delphij.net (Postfix) with ESMTPSA id 5A6793581;
	Wed, 16 Nov 2011 10:07:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis;
	t=1321466835; bh=jkJZaJhX/rrEb0YD/QYLuIEo+8OTJy3BAaSuUsRvJbc=;
	h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject:
	References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=YFrq1LZwtR8fpuzwW1+bPyCOMO0G7rDYrcSFxEdJjywyBcv7sd+re5tockDUrmdlT
	9Dtsb61soQNZMpndXW0L3Kaue0USEluiDGzD45W8IVyTcu1lUC7l12LYZkEbWQE95O
	jp97XT4JbE1UMDRYcDbQffEmxkPES0Dak3bcX8bE=
Message-ID: <4EC3FBD2.4070009@delphij.net>
Date: Wed, 16 Nov 2011 10:07:14 -0800
From: Xin LI <delphij@delphij.net>
Organization: The FreeBSD Project
MIME-Version: 1.0
To: Robert Millan <rmh@freebsd.org>
References: <CAOfDtXPX1Rv9T7+1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
In-Reply-To: <CAOfDtXPX1Rv9T7+1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
OpenPGP: id=3FCA37C1;
	url=http://www.delphij.net/delphij.asc
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>,
	freebsd-current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: d@delphij.net
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2011 18:07:16 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11/16/11 09:27, Robert Millan wrote:
> Hi!
> 
> Out of the kernel headers that are installed in /usr/include/
> hierracy, there are some which include support multiple operating
> systems (usually FreeBSD and other *BSD flavours).
> 
> This patch adds support to detect GNU/kFreeBSD as well.  In all
> cases, we match the same declarations as FreeBSD does (which is to
> be expected in kernel headers, since both systems share the same
> kernel).
> 
> Does it look fine?

Just my $0.02 -- I think we should probably do it in a more
centralized place -- otherwise in case someone imported some new code,
they have to do the same defined(__FreeBSD__) ||
defined(__FreeBSD_kernel__)?

Cheers,
- -- 
Xin LI <delphij@delphij.net>	https://www.delphij.net/
FreeBSD - The Power to Serve!		Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBCAAGBQJOw/vSAAoJEATO+BI/yjfBozIIAMuqmkNkDkWG4Kra/mQ5HQXZ
Oe/bndGzfUl9H6epFZWc+eeT2zxnlvVUGwVf5si3THU23dZkmynbPj1NnY+oDewt
TwB5nbG0tcClMMesK8L9lJB5AxKHsRtILK8l8xMzsJEj6fRjb8+yrjj8LLK7zUNk
gTQA/sOVR2a4ZARkUlvbgNsE/BBx7NijxFS3uMA91AgsXAniBp4ND6dDwAudQIpW
MqLH4DxJX/6EC2E9ibM5IBB8wguaUWF52oHLGnRAs2JkXzNS/qj6aSepjivSIUzh
gtKKteCpRNexnWq+2pym9OE6tmxW8uoPNUuBxZqOP+laabcn392silZrE0yElh8=
=XHtJ
-----END PGP SIGNATURE-----