From owner-svn-ports-all@FreeBSD.ORG  Sat Oct 19 21:39:06 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9F1C7482;
 Sat, 19 Oct 2013 21:39:06 +0000 (UTC)
 (envelope-from nox@jelal.kn-bremen.de)
Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116])
 by mx1.freebsd.org (Postfix) with ESMTP id 58B782278;
 Sat, 19 Oct 2013 21:39:05 +0000 (UTC)
Received: by smtp.kn-bremen.de (Postfix, from userid 10)
 id 198A81E007B5; Sat, 19 Oct 2013 23:39:05 +0200 (CEST)
Received: from enceladus10.kn-bremen.de (noident@localhost [127.0.0.1])
 by enceladus10.kn-bremen.de (8.14.5/8.14.5) with ESMTP id r9JLbLt3034377;
 Sat, 19 Oct 2013 23:37:21 +0200 (CEST)
 (envelope-from nox@enceladus10.kn-bremen.de)
Received: (from nox@localhost)
 by enceladus10.kn-bremen.de (8.14.5/8.14.5/Submit) id r9JLbLP0034376;
 Sat, 19 Oct 2013 23:37:21 +0200 (CEST) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Sat, 19 Oct 2013 23:37:21 +0200
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r330781 - in head/www/vdr-plugin-live: . files
Message-ID: <20131019213721.GA34367@enceladus10.kn-bremen.de>
References: <201310182230.r9IMUHGJ058516@svn.freebsd.org>
 <20131019133626.GA15196@FreeBSD.org>
 <20131019205731.GA26972@enceladus10.kn-bremen.de>
 <20131019213405.GA32859@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131019213405.GA32859@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, Juergen Lock <nox@FreeBSD.org>,
 svn-ports-all@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Oct 2013 21:39:06 -0000

On Sat, Oct 19, 2013 at 09:34:05PM +0000, Alexey Dokuchaev wrote:
> On Sat, Oct 19, 2013 at 10:57:31PM +0200, Juergen Lock wrote:
> > On Sat, Oct 19, 2013 at 01:36:26PM +0000, Alexey Dokuchaev wrote:
> > > On Fri, Oct 18, 2013 at 10:30:17PM +0000, Juergen Lock wrote:
> > > > New Revision: 330781
> > > > URL: http://svnweb.freebsd.org/changeset/ports/330781
> > > > [...]
> > > > +pre-install:
> > > > +	${MKDIR} ${PREFIX}/lib/vdr
> > > > +
> > > 
> > > Hmm, since it's unstaged port, it looks like pre-install should really be
> > > pre-su-install, otherwise it will fail unless built/installed by root, if
> > > I'm not mistaken.
> > 
> > Hm I guess you're right, even tho it probably won't matter much in
> > practice as the mkdir is only needed when PREFIX is != LOCALBASE
> > and vdr itself is installed in LOCALBASE and created the dir there,
> > which means this cannot really run anyway.
> 
> I see.  Provided that your analysis is correct, I guess there is no need
> for immediate action, since this issue would become void anyways once
> the port would be stagified.
> 
> ./danfe

I fixed it nevertheless, be it only not to serve as a bad example. :)

 Thanx,
	Juergen