From owner-svn-src-head@FreeBSD.ORG Tue Jun 21 14:40:12 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE9661065674; Tue, 21 Jun 2011 14:40:12 +0000 (UTC) (envelope-from guy.helmer@palisadesystems.com) Received: from ps-2-a.compliancesafe.com (ps-2-a.compliancesafe.com [216.81.161.163]) by mx1.freebsd.org (Postfix) with ESMTP id 6F99A8FC16; Tue, 21 Jun 2011 14:40:12 +0000 (UTC) Received: from mail.palisadesystems.com (localhost.compliancesafe.com [127.0.0.1]) by ps-2-a.compliancesafe.com (8.14.4/8.14.3) with ESMTP id p5LEDqOS044711; Tue, 21 Jun 2011 09:13:52 -0500 (CDT) (envelope-from guy.helmer@palisadesystems.com) Received: from guysmbp.dyn.palisadesys.com (GuysMBP.dyn.palisadesys.com [172.16.2.90]) (authenticated bits=0) by mail.palisadesystems.com (8.14.3/8.14.3) with ESMTP id p5LEDjCw032591 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 21 Jun 2011 09:13:46 -0500 (CDT) (envelope-from guy.helmer@palisadesystems.com) X-DKIM: Sendmail DKIM Filter v2.8.3 mail.palisadesystems.com p5LEDjCw032591 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=palisadesystems.com; s=mail; t=1308665627; bh=QReqI2toiDtyqfrWzJ1Xa76muHycMexXERopW+Q6Apk=; l=128; h=Subject:Mime-Version:Content-Type:From:In-Reply-To:Date:Cc: Content-Transfer-Encoding:Message-Id:References:To; b=VlVng96NdbBo0e2Zv1ZPDFrRqx1RNe9kdCmQdXORAeZ+od2BaMgQWhRQ9ecMVjTh5 IeWP9ViutKIXrcHDGPzDT/cIUck41pEaz7klIeKMrU92EdmO/tl3jkxbXwFJwsM8UQ z1N3YK9hJgRZ4ON6Geqo7VG0qiVC5yBCAqUzLfm0= Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Guy Helmer In-Reply-To: <201106210907.18414.jhb@freebsd.org> Date: Tue, 21 Jun 2011 09:13:45 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <5DCAB741-793C-4595-A83D-CC89D9D14A13@palisadesystems.com> References: <201106202259.p5KMxT1h069297@svn.freebsd.org> <201106210907.18414.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.5 (mail.palisadesystems.com [172.16.1.5]); Tue, 21 Jun 2011 09:13:47 -0500 (CDT) X-Palisade-MailScanner-Information: Please contact the ISP for more information X-Palisade-MailScanner-ID: p5LEDjCw032591 X-Palisade-MailScanner: Found to be clean X-Palisade-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-Palisade-MailScanner-From: guy.helmer@palisadesystems.com X-Spam-Status: No X-PacketSure-Scanned: Yes Cc: Jack F Vogel , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r223350 - head/sys/dev/e1000 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 14:40:12 -0000 On Jun 21, 2011, at 8:07 AM, John Baldwin wrote: > On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: >> Author: jfv >> Date: Mon Jun 20 22:59:29 2011 >> New Revision: 223350 >> URL: http://svn.freebsd.org/changeset/base/223350 >>=20 >> Log: >> Eliminate some global tuneables in favor of adapter-specific, >> particular flow control and dma coalesce. Also improve the >> sysctl operation on those too. >>=20 >> Add IPv6 detection in the ioctl code, this was done for >> ixgbe first, carrying that over. >>=20 >> Add resource ability to disable particular adapter. >>=20 >> Add HW TSO capability so vlans can make use of TSO >=20 > The tunables are useful for setting defaults for all interfaces. :( >=20 > I use hw.igb.rx_processing_limit=3D-1 in loader.conf at work so that = we can=20 > ensure that all igb interfaces in a given system have that setting. = This is=20 > more scalable than having to set the right number of entries in=20 > /etc/sysctl.conf.local on different machines, etc, without spamming = the=20 > console during boot with warnings about tweaking non-existing sysctls, = etc. >=20 > Please consider keeping the tunables where the tunables are used to = set > default settings for all adapters from the loader but per-device = sysctls are > used post-boot to provide runtime, per-device settings. I agree. Guy -------- This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.