From owner-freebsd-net@freebsd.org Tue Jun 6 10:00:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7A28BFB96A for ; Tue, 6 Jun 2017 10:00:17 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 51E3415BB for ; Tue, 6 Jun 2017 10:00:17 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id v569xVtE061644; Tue, 6 Jun 2017 11:59:31 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id F02F58B8; Tue, 6 Jun 2017 11:59:30 +0200 (CEST) Message-ID: <59367CF5.9080101@omnilan.de> Date: Tue, 06 Jun 2017 11:59:17 +0200 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Vincenzo Maffione CC: freebsd-net Subject: Re: ovs-netmap forgotten? References: <5926FFDB.7040900@omnilan.de> <592F20A0.4020702@omnilan.de> <592FC60A.1030308@omnilan.de> <5935A20A.6040000@omnilan.de> In-Reply-To: <5935A20A.6040000@omnilan.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Tue, 06 Jun 2017 11:59:31 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 10:00:17 -0000 Bezüglich Harry Schmalzbauer's Nachricht vom 05.06.2017 20:25 (localtime): > Bezüglich Vincenzo Maffione's Nachricht vom 05.06.2017 16:06 (localtime): > … > First quick test shows you're right and this tiny diff solves a decent > share of my (ESXi-replacing) problems: > > --- src/sys/net/if_vlan.c.orig 2017-06-05 17:39:27.770574000 +0200 > +++ src/sys/net/if_vlan.c 2017-06-05 17:39:21.550278000 +0200 > @@ -1234,7 +1234,7 @@ > if_inc_counter(ifv->ifv_ifp, IFCOUNTER_IPACKETS, 1); > > /* Pass it back through the parent's input routine. */ > - (*ifp->if_input)(ifv->ifv_ifp, m); > + (*ifv->ifv_ifp->if_input)(ifv->ifv_ifp, m); > } > > static int > > Will do real-world tests tommorrow. To share my observations: Attaching if_vlan(4) to vale(4) works with the above modification, as long as vlanhwtag is _not_ disabled, at least with igb(4) and (em4). Having other offloadings enabled or disabled (regardless if it's on parent or vlan-clone) doesn't matter, disabling vlanhwtag on the parent leads to congested parent if there's mor etraffic than console... I haven't done any tracking if it's caused by TCP windows scaling e.g. nor tried to ask the code, because I do want vlanhwtagging enabled and that's what works so far :-) This is also true for if_vlan(4) interfaces which have if_lagg(0) as parent, and also for both types of vale(4) attaching, hoststack-detached (-a) or hoststack-attached (-h). So far very nice :-) But there's a interrupt multiplication noticeable (at the host). My simple NFS-copying test causes ~10ki/s at one igb(4) queue when invoked on the host, with mtu 1500. Same invocation in the guest, with vlan-vale setup, causes 30ki/s average (with high discrepancy, 20-40k). Might it be possible that if_vlan(4) influences interrupt moderation capabilities? Vincenzo, thanks for your answers to my questions, which I read during writing of this - stripping them here. -harry