From owner-svn-src-head@FreeBSD.ORG Wed Apr 6 15:45:33 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28E381065672; Wed, 6 Apr 2011 15:45:33 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 1A3E18FC15; Wed, 6 Apr 2011 15:45:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p36FjWik096064; Wed, 6 Apr 2011 15:45:32 GMT (envelope-from gallatin@svn.freebsd.org) Received: (from gallatin@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p36FjWXr096062; Wed, 6 Apr 2011 15:45:32 GMT (envelope-from gallatin@svn.freebsd.org) Message-Id: <201104061545.p36FjWXr096062@svn.freebsd.org> From: Andrew Gallatin Date: Wed, 6 Apr 2011 15:45:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220385 - head/sys/dev/mxge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2011 15:45:33 -0000 Author: gallatin Date: Wed Apr 6 15:45:32 2011 New Revision: 220385 URL: http://svn.freebsd.org/changeset/base/220385 Log: Implement mxge_init() This fixes a long standing bug in mxge(4) where "ifconfig mxge0 $IP" did not bring the interface into a RUNNING state, like it does on most (all?) other FreeBSD NIC drivers. Thanks to gnn for mentioning the bug, and yongari for pointing out that ether_ioctl() invokes ifp->if_init() in SIOCSIFADDR. MFC after: 7 days Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c ============================================================================== --- head/sys/dev/mxge/if_mxge.c Wed Apr 6 15:36:19 2011 (r220384) +++ head/sys/dev/mxge/if_mxge.c Wed Apr 6 15:45:32 2011 (r220385) @@ -3054,6 +3054,14 @@ mxge_intr(void *arg) static void mxge_init(void *arg) { + mxge_softc_t *sc = arg; + struct ifnet *ifp = sc->ifp; + + + mtx_lock(&sc->driver_mtx); + if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) + (void) mxge_open(sc); + mtx_unlock(&sc->driver_mtx); }