Date: Thu, 30 Mar 2017 18:52:35 +0300 From: Toomas Soome <tsoome@me.com> To: FreeBSD Current <freebsd-current@freebsd.org> Subject: D10203: loader: zfs reader should check all labels Message-ID: <F578CCBD-A2B6-4275-823F-FB2D44860A1C@me.com> References: <differential-rev-PHID-DREV-jf5iuvkdj2vr6uxiqx7v-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! Sorry about forward, but this patch is something a bit more complicated = and if we have some people willing to test, it would be really nice:) I = have had it around for my illumos port for some time now, but those = small details about the zfsboot/gptzfsboot etc sometimes do count a = lot=E2=80=A6=20 thanks, toomas > Begin forwarded message: >=20 > From: "tsoome (Toomas Soome)" <phabric-noreply@FreeBSD.org> > Subject: [Differential] D10203: loader: zfs reader should check all = labels > Date: 30. m=C3=A4rts 2017 18:39.44 GMT+3 > To: tsoome@me.com > Reply-To: D10203+574+d76c8a36ba3c3f0a@reviews.freebsd.org >=20 > tsoome created this revision. > Herald added a subscriber: delphij. >=20 > REVISION SUMMARY > The current zfs reader is only checking first label from each device, = however, > we do have 4 labels on device and we should check all 4 to be = protected > against disk failures and incomplete label updates. >=20 > The difficulty is about the fact that 2 label copies are in front of = the > pool data, and 2 are at the end, which means, we have to know the = size of > the pool data area. >=20 > Since we have now the mechanism from common/disk.c to use the = partition > information, it does help us in this task; however, there are still = some > corner cases. >=20 > Namely, if the pool is created without partition, directly on the = disk, > and firmware will give us the wrong size for the disk, we only can = check > the first two label copies. >=20 > REPOSITORY > rS FreeBSD src repository >=20 > REVISION DETAIL > https://reviews.freebsd.org/D10203 >=20 > AFFECTED FILES > sys/boot/efi/boot1/zfs_module.c > sys/boot/efi/loader/main.c > sys/boot/i386/common/drv.h > sys/boot/i386/loader/main.c > sys/boot/i386/zfsboot/zfsboot.c > sys/boot/zfs/libzfs.h > sys/boot/zfs/zfsimpl.c >=20 > EMAIL PREFERENCES > https://reviews.freebsd.org/settings/panel/emailpreferences/ >=20 > To: tsoome, allanjude, imp, avg > Cc: delphij
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F578CCBD-A2B6-4275-823F-FB2D44860A1C>