From owner-freebsd-current@FreeBSD.ORG Mon Jun 2 08:18:20 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6985937B404; Mon, 2 Jun 2003 08:18:20 -0700 (PDT) Received: from heron.mail.pas.earthlink.net (heron.mail.pas.earthlink.net [207.217.120.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id D136443F85; Mon, 2 Jun 2003 08:18:19 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from user-38ldshk.dialup.mindspring.com ([209.86.242.52] helo=mindspring.com) by heron.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 19Mr4k-0002x2-00; Mon, 02 Jun 2003 08:18:19 -0700 Message-ID: <3EDB6A6F.827B7C22@mindspring.com> Date: Mon, 02 Jun 2003 08:17:03 -0700 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Hiten Pandya References: <20030602014757.GA99626@perrin.int.nxad.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a4ce7eeb9b5298c82ac4c812afc3df9791667c3043c0873f7e350badd9bab72f9c350badd9bab72f9c cc: current@FreeBSD.ORG cc: des@FreeBSD.ORG Subject: Re: VFS: C99 sparse format for struct vfsops X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2003 15:18:20 -0000 Hiten Pandya wrote: > My fingers have been itching to do this since the day phk@ planted this > idea in my brain (re: cdevsw initialisations). Basically, it changes > the vfsops to use C99 sparse format, just like cdevsw. It removes a lot > of junk default initialisations, and duplication. I really dislike the changes to vfs_init(). Specifically, it's not the overhead, so much as it's the implied side effects. Consider this going forward: someone adds a new VFSOP to the list of allowable VFSOPs, and the vfs_init() doesn't have any specific code for it. This could happen with a new VFS implementation that gets loaded as a module. While the current code can't really handle this well, the changes move us further away from ever being able to handle something like this. 8-(. -- Terry