From owner-freebsd-current Fri Jul 2 18:47:58 1999 Delivered-To: freebsd-current@freebsd.org Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (Postfix) with ESMTP id 3EF5B151D5 for ; Fri, 2 Jul 1999 18:47:48 -0700 (PDT) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.9.2/8.8.7) with ESMTP id VAA13173; Fri, 2 Jul 1999 21:47:48 -0400 (EDT) Date: Fri, 2 Jul 1999 21:47:48 -0400 (EDT) From: "Brian F. Feldman" X-Sender: green@janus.syracuse.net To: Greg Lehey Cc: current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: <19990703093223.V87392@freebie.lemis.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 3 Jul 1999, Greg Lehey wrote: > On Friday, 2 July 1999 at 15:26:35 -0400, Brian F. Feldman wrote: > > On Fri, 2 Jul 1999, Brian F. Feldman wrote: > > > >> Here's the fix. I'm sure it's not absolutely the same as what Greg will have, > >> but if anyone wants to commit it, it will fix world. > > > > I know I _could_ commit it, but it's someone else's work that's being actively > > maintained. It still does break world, but I don't think I have authority to > > commit over Greg's work. > > I personally think that, in such a case, you'd be justified to commit > it as a temporary measure. Due to the difference in time zones, this > has hit people while I've been asleep. That doesn't mean the commit > would stay, of course, but at least it would save people unnecessary > pain. Note, of course, that I have now committed the correct file, > which I had forgotten last night. This is exactly how I felt. I knew that what I was doing was correct, even if it wasn't the same as what you had, and you would fix it up when you had the chance. However, I had no case to set a precedent of what to do; last time vinum was broken for a long time because phk's changes didn't get reviewed for a while; he didn't want things to go wrong, so he didn't commit it. This was simpler, but I didn't want to do things that are wrong. > > What do you others think? > > Greg > -- > See complete headers for address, home page and phone numbers > finger grog@lemis.com for PGP public key > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___ green@FreeBSD.org _ __ ___ | _ ) __| \ FreeBSD: The Power to Serve! _ __ | _ \._ \ |) | http://www.FreeBSD.org/ _ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message