From owner-freebsd-hackers@freebsd.org Fri Aug 4 02:17:38 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86464DBEEE9 for ; Fri, 4 Aug 2017 02:17:38 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5854C7505B for ; Fri, 4 Aug 2017 02:17:38 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-pf0-x232.google.com with SMTP id c28so1327886pfe.3 for ; Thu, 03 Aug 2017 19:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Ka9t1+JsjY43jc8fNfMSz7AnMrTIU7QFUF7iSQyHKnc=; b=SmLqBd2P0cQIqTENt2kvIiKdXS2WW6QMyRubgqno1hc4BaQzFW+Z3HlmoTeuPNzDQt P/ujfk2OIocBGGjHVtWRI1UEKyGOBC6aONrP87YBxi7TJF1shVowDHYjQB88fvNSp1u+ 10vLdAjISQjh0xYNIQ+3VRuGtz9TRQn2qUewKiYqI85I8nP9HFxzEv7oPklCF3INp1tG 9Fg9m0wL2Ny6ENCQBD+tUVgcjDz3CGd7vJik/hlhSzCFD3JVtPXXia5sTwiiUxKoM2nf 4YOq4IvkXOn/t50cHEUFdhU2wbaSCEE56zPKI669jpRyhAP90QezGOfggUd876p+Jh/X 19AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Ka9t1+JsjY43jc8fNfMSz7AnMrTIU7QFUF7iSQyHKnc=; b=RxXaslqM5SUSlVVEmvcs8e6wxwRf4jrrK0fUSX6mokE9aIPE4x5n7hIINCdrckfm6B 4hytEfhQkkln1SfV+imHT+TYiR4wiUWRvTyK6mLqXDrBhtPPQDDMJAStK92BtaZiAuJd 2xNiIXIiqYJC97sbKPfCqI8YEBk5zmvdE9ZPR4CrFsUSKEelzx1Ddu/+2woVGJvgkKrA 5VUbISXJ8pFEtOi9c6S1e1PJuuruG4F6w7C/Tp8+o4STWG/R5pXVeXnEj/V8TnxHw6VM AdNrf7FXkegJTTz7uLi4rbD5w7aVpldEdOTF64Kr6BzC+Xfmw8oy0CA7gUhIaY0NcYg1 OUyQ== X-Gm-Message-State: AIVw113+ZHok8hyblZ2vq/zGWBVpx6pzzTWWAHsm9/lk7BII+Bk08Qa3 Kk3wcuZmYkY3EUdRctIt28cI6EdcO5NSqfs= X-Received: by 10.98.112.137 with SMTP id l131mr838657pfc.194.1501813057558; Thu, 03 Aug 2017 19:17:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.183.208 with HTTP; Thu, 3 Aug 2017 19:17:17 -0700 (PDT) From: Farhan Khan Date: Thu, 3 Aug 2017 22:17:17 -0400 Message-ID: Subject: PCI bus detaching when driver crashing? To: freebsd-hackers@freebsd.org X-Mailman-Approved-At: Fri, 04 Aug 2017 03:19:09 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 02:17:38 -0000 Hi all, I am trying to write the Realtek 8188e (pci) driver for FreeBSD. I am making slow incremental progress, and having the driver safely exit out (as opposed to a segfault). I noticed that when the device detaches, due to an error in the driver, the entire pci bus will also detach! For example, here is my kernel output: rtwn0: rtwn_load_firmware: failed to upload firmware rtwn-rtl8188eefw (error 60) rtwn0: detached pci2: detached The first line is where the code crashes: sys/dev/rtwn/if_rtwn_fw.c line 129 https://github.com/khanzf/freebsd/blob/103c05369b1ced770a2cadc9468e0134c8d9421b/sys/dev/rtwn/if_rtwn_fw.c#L129 Why would this result in the entire pci2 bus detatching? Strangely enough, I did not have this problem a few months ago, then it suddenly began. This is significantly slowing down my workflow, and would be nice to have it resolved. Otherwise, I have to reboot to bring pci2 back up. Any insight? Thanks! Farhan Khan