Date: Mon, 13 Apr 2015 20:56:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199428] [patch] ports-mgmt/portlint: make sure that first-paragraph things appear in the first paragraph Message-ID: <bug-199428-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199428 Bug ID: 199428 Summary: [patch] ports-mgmt/portlint: make sure that first-paragraph things appear in the first paragraph Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: adamw@FreeBSD.org Keywords: patch Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Created attachment 155566 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155566&action=edit patch The list of things from the first section (PORTNAME) that gets checked for order (checkorder()) contains things that aren't checked by checkearlier(). The consequence of this is that those items only get checked if they appear in the first section. If they appear elsewhere in the Makefile, portlint doesn't catch it. Joe, I think that the list of items on line 2668 should be the same as the list on line 2307... do I have that right? If my logic is correct there, the attached patch makes those two lists identical. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199428-13>