From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Apr 13 20:56:55 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B7FA3672
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 13 Apr 2015 20:56:55 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9C1E7792
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 13 Apr 2015 20:56:55 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t3DKutOG027447
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 13 Apr 2015 20:56:55 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 199428] [patch] ports-mgmt/portlint: make sure that
 first-paragraph things appear in the first paragraph
Date: Mon, 13 Apr 2015 20:56:55 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: adamw@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: marcus@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter flagtypes.name attachments.created
Message-ID: <bug-199428-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2015 20:56:55 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199428

            Bug ID: 199428
           Summary: [patch] ports-mgmt/portlint: make sure that
                    first-paragraph things appear in the first paragraph
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: adamw@FreeBSD.org
          Keywords: patch
          Assignee: marcus@FreeBSD.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)

Created attachment 155566
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155566&action=edit
patch

The list of things from the first section (PORTNAME) that gets checked for
order (checkorder()) contains things that aren't checked by checkearlier().

The consequence of this is that those items only get checked if they appear in
the first section. If they appear elsewhere in the Makefile, portlint doesn't
catch it.

Joe, I think that the list of items on line 2668 should be the same as the list
on line 2307... do I have that right? If my logic is correct there, the
attached patch makes those two lists identical.

-- 
You are receiving this mail because:
You are the assignee for the bug.