From owner-freebsd-bugs  Tue May 22  6:20:10 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 433A037B424
	for <freebsd-bugs@hub.freebsd.org>; Tue, 22 May 2001 06:20:04 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4MDK4617675;
	Tue, 22 May 2001 06:20:04 -0700 (PDT)
	(envelope-from gnats)
Date: Tue, 22 May 2001 06:20:04 -0700 (PDT)
Message-Id: <200105221320.f4MDK4617675@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Bruce Evans <bde@zeta.org.au>
Subject: Re: bin/27480: [PATCH] fixes to jot(1) from OpenBSD
Reply-To: Bruce Evans <bde@zeta.org.au>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/27480; it has been noted by GNATS.

From: Bruce Evans <bde@zeta.org.au>
To: dd@FreeBSD.ORG
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/27480: [PATCH] fixes to jot(1) from OpenBSD
Date: Tue, 22 May 2001 23:14:16 +1000 (EST)

 > The attached patch fixes some overflows in jot(1) and syncs up to
 > OpenBSD a little.  Significant changes include:
 > 
 >         - use getopt
 >         - de-register
 >         - fix overflows in -b and -w options; old behavior:
 >...
 >         - use strlcpy and snprintf
 >         - check return values of the above
 >         - fix other gratuituos diffs to OpenBSD; not a complete sync,
 >           but better than nothing
 
 I would prefer to see the cleanups separately.  Especially the getopt
 changes which merge getargs() into main() and rename av to argv.
 
 > I've sent this to -audit; it elicited comments about breaking K&R,
 > which I addressed, but no solid reviews.
 
 I noticed only a couple of minor style problems (similar to ones in
 the original code).
 
 You've done more than enough time as a ports-only (?) committer and
 should commit things more directly.  Reviews are good of course if
 you can get them promptly.
 
 Bruce
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message