Date: Tue, 14 Jul 2009 08:59:48 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, "Rashid N. Achilov" <citycat4@ngs.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/flowd Makefile ports/net-mgmt/flowd/files flowd.in Message-ID: <20090714125948.GH76004@atarininja.org> In-Reply-To: <4A5C1EFE.5060609@FreeBSD.org> References: <200907131622.n6DGMuOa014201@repoman.freebsd.org> <4A5C1EFE.5060609@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 13, 2009 at 11:00:30PM -0700, Doug Barton wrote: > Wesley Shields wrote: > > wxs 2009-07-13 16:22:56 UTC > > > > FreeBSD ports repository > > > > Modified files: > > net-mgmt/flowd Makefile > > Added files: > > net-mgmt/flowd/files flowd.in > > Log: > > - Install RC script. > > > > PR: ports/135949 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=135949 > > Submitted by: Rashid N. Achilov <citycat4@ngs.ru> > > Approved by: maintainer timeout > > > > Revision Changes Path > > 1.14 +2 -0 ports/net-mgmt/flowd/Makefile > > 1.1 +30 -0 ports/net-mgmt/flowd/files/flowd.in (new) > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/Makefile.diff?&r1=1.13&r2=1.14&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/files/flowd.in > > > Overall this looks quite good, thanks! The only thing I would change > is to eliminate the empty _flags assignment, and include that in the > example comments at the top. You might also want to s/ipcad/flowd/. :) Fixed, thanks! -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090714125948.GH76004>