From owner-svn-src-all@FreeBSD.ORG Sun Apr 17 16:31:21 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C26F81065670; Sun, 17 Apr 2011 16:31:21 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B09748FC13; Sun, 17 Apr 2011 16:31:21 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p3HGVLvp043310; Sun, 17 Apr 2011 16:31:21 GMT (envelope-from glebius@svn.freebsd.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p3HGVLss043308; Sun, 17 Apr 2011 16:31:21 GMT (envelope-from glebius@svn.freebsd.org) Message-Id: <201104171631.p3HGVLss043308@svn.freebsd.org> From: Gleb Smirnoff Date: Sun, 17 Apr 2011 16:31:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220745 - head/sys/netgraph X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 16:31:21 -0000 Author: glebius Date: Sun Apr 17 16:31:21 2011 New Revision: 220745 URL: http://svn.freebsd.org/changeset/base/220745 Log: Fix error where error variable was assigned result of comparison, instead of function return value. Submitted by: Przemyslaw Frasunek MFC after: 4 days Modified: head/sys/netgraph/ng_base.c Modified: head/sys/netgraph/ng_base.c ============================================================================== --- head/sys/netgraph/ng_base.c Sun Apr 17 16:18:45 2011 (r220744) +++ head/sys/netgraph/ng_base.c Sun Apr 17 16:31:21 2011 (r220745) @@ -596,7 +596,7 @@ ng_make_node(const char *typename, node_ */ if (type->constructor != NULL) { if ((error = ng_make_node_common(type, nodepp)) == 0) { - if ((error = ((*type->constructor)(*nodepp)) != 0)) { + if ((error = ((*type->constructor)(*nodepp))) != 0) { NG_NODE_UNREF(*nodepp); } }