Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Apr 2011 16:31:21 +0000 (UTC)
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r220745 - head/sys/netgraph
Message-ID:  <201104171631.p3HGVLss043308@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: glebius
Date: Sun Apr 17 16:31:21 2011
New Revision: 220745
URL: http://svn.freebsd.org/changeset/base/220745

Log:
  Fix error where error variable was assigned result of comparison,
  instead of function return value.
  
  Submitted by:	Przemyslaw Frasunek <przemyslaw frasunek.com>
  MFC after:	4 days

Modified:
  head/sys/netgraph/ng_base.c

Modified: head/sys/netgraph/ng_base.c
==============================================================================
--- head/sys/netgraph/ng_base.c	Sun Apr 17 16:18:45 2011	(r220744)
+++ head/sys/netgraph/ng_base.c	Sun Apr 17 16:31:21 2011	(r220745)
@@ -596,7 +596,7 @@ ng_make_node(const char *typename, node_
 	 */
 	if (type->constructor != NULL) {
 		if ((error = ng_make_node_common(type, nodepp)) == 0) {
-			if ((error = ((*type->constructor)(*nodepp)) != 0)) {
+			if ((error = ((*type->constructor)(*nodepp))) != 0) {
 				NG_NODE_UNREF(*nodepp);
 			}
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104171631.p3HGVLss043308>