Date: Sun, 21 Jan 2018 15:21:16 -0700 From: Adam Weinberger <adamw@adamw.org> To: Chris Rees <crees@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r459630 - in head/mail/openwebmail: . files Message-ID: <F66245DA-F581-4370-8EFC-F63628DBE994@adamw.org> In-Reply-To: <201801212214.w0LMElpt069984@repo.freebsd.org> References: <201801212214.w0LMElpt069984@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21 Jan, 2018, at 15:14, Chris Rees <crees@FreeBSD.org> wrote: > > Author: crees > Date: Sun Jan 21 22:14:47 2018 > New Revision: 459630 > URL: https://svnweb.freebsd.org/changeset/ports/459630 > > Log: > Correct array checks > > Submitted by: Emil Barta > > Modified: > head/mail/openwebmail/Makefile > head/mail/openwebmail/files/patch-fix-perl > > Modified: head/mail/openwebmail/Makefile > ============================================================================== > --- head/mail/openwebmail/Makefile Sun Jan 21 21:43:07 2018 (r459629) > +++ head/mail/openwebmail/Makefile Sun Jan 21 22:14:47 2018 (r459630) > @@ -3,7 +3,7 @@ > > PORTNAME= openwebmail > PORTVERSION= 2.53 > -PORTREVISION= 3 > +PORTREVISION= 4 > CATEGORIES= mail > MASTER_SITES= http://openwebmail.acatysmoof.com/download/release/ \ > http://openwebmail.org/openwebmail/download/release/ > > Modified: head/mail/openwebmail/files/patch-fix-perl > ============================================================================== > --- head/mail/openwebmail/files/patch-fix-perl Sun Jan 21 21:43:07 > 2018 (r459629) > +++ head/mail/openwebmail/files/patch-fix-perl Sun Jan 21 22:14:47 > 2018 (r459630) > @@ -69,7 +69,7 @@ diff -ruN openwebmail/shares/mailfilter.pl openwebmail > } > } > - if (!defined @{$r_attachments}) { > -+ if (!@{$r_attachments}) { > ++ if (!ref{$r_attachments}) { > ($header, $body, $r_attachments)=ow::mailparse::parse_rfc822block(\$currmessage); > } > > @@ -78,7 +78,7 @@ diff -ruN openwebmail/shares/mailfilter.pl openwebmail > } > } > - if (!defined @{$r_attachments}) { > -+ if (!@{$r_attachments}) { > ++ if (!ref{$r_attachments}) { Hi Chris, Are you sure about this change? {...} defines a hash reference, so I believe ref{...} will always be true. Did you want just "ref $r_attachments" instead? # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F66245DA-F581-4370-8EFC-F63628DBE994>