From owner-svn-ports-head@FreeBSD.ORG Sun Mar 10 16:24:35 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 51726A25; Sun, 10 Mar 2013 16:24:35 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155]) by mx1.freebsd.org (Postfix) with ESMTP id 1026664E; Sun, 10 Mar 2013 16:24:35 +0000 (UTC) Received: from winston.madpilot.net (localhost [127.0.0.1]) by winston.madpilot.net (Postfix) with ESMTP id 3ZP77h6PDbzFTJ7; Sun, 10 Mar 2013 17:24:32 +0100 (CET) X-Virus-Scanned: amavisd-new at madpilot.net Received: from winston.madpilot.net ([127.0.0.1]) by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C_sCJdRWrE9F; Sun, 10 Mar 2013 17:24:30 +0100 (CET) Received: from tommy.madpilot.net (micro.madpilot.net [88.149.173.206]) by winston.madpilot.net (Postfix) with ESMTPSA; Sun, 10 Mar 2013 17:24:30 +0100 (CET) Message-ID: <513CB3BF.7030809@FreeBSD.org> Date: Sun, 10 Mar 2013 17:24:31 +0100 From: Guido Falsi User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130220 Thunderbird/17.0.3 MIME-Version: 1.0 To: Max Brazhnikov Subject: Re: svn commit: r313682 - in head/comms/openobex: . files References: <201303090039.r290dh5G031351@svn.freebsd.org> <9879549.96OiXCOr5y@mercury.ph.man.ac.uk> <513CA44C.3060402@FreeBSD.org> In-Reply-To: <513CA44C.3060402@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Mar 2013 16:24:35 -0000 On 03/10/13 16:18, Guido Falsi wrote: > On 03/09/13 20:48, Max Brazhnikov wrote: >> On Sat, 09 Mar 2013 00:39:43 +0000Sat Mar 9 00:39:43 2013 Guido Falsi >> wrote: >>> - Add DOXYGEN option, disabled by default to keep the port slim >> >> I've disabled all options in doxygen recently, it's pretty light now. > > I noticed. I can enable this one by default without problems. > >> >>> +.if ${PORT_OPTIONS:MDOXYGEN} >>> +BUILD_DEPENDS+= doxygen:${PORTSDIR}/devel/doxygen >>> +PORTDOCS= * >>> .else >> >> PORTDOCS should only be use with DOCS option, otherwise packaging will >> fail if >> DOXYGEN is set and DOCS is unset. > > But the doxygen files are being put in DOCSDIR by this port. > > I also thought I could make the OPTION be DOCS instead of DOXYGEN, > which, for this port, seems to be the same, would this be acceptable? > > This would also make the option enabled by default. Pleae disregard the above comment. I was misunderstanding how doxygen works. I'll fix the plist and Makefile not to use PORTDOCS. I'll also see to make DOXYGEN the default. Thanks for reporting! -- Guido Falsi