From owner-freebsd-arch Fri Feb 22 10:36: 3 2002 Delivered-To: freebsd-arch@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 2A9C937B404; Fri, 22 Feb 2002 10:35:54 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g1MIZsZ18088; Fri, 22 Feb 2002 10:35:54 -0800 (PST) (envelope-from dillon) Date: Fri, 22 Feb 2002 10:35:54 -0800 (PST) From: Matthew Dillon Message-Id: <200202221835.g1MIZsZ18088@apollo.backplane.com> To: John Baldwin Cc: Julian Elischer , arch@FreeBSD.ORG Subject: Re: RE: that INVARIANT/ucred freeing stuff. References: Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :>:John Baldwin <>< http://www.FreeBSD.org/~jhb/ :> :> Don't try to overengineer the problem. Unless you believe there is :> a serious problem, there is no need to put a check in every single :> conceivable place an error might occur. Just putting a few safety checks :> in a few critical places should be sufficient. : :I don't know where all the places we might look at a ucred wrongly are. That's :why I wanted the much simpler solution of just clearing td_ucred to NULL so we :had an implicit KASSERT for us in all those places. : :-- : :John Baldwin <>< http://www.FreeBSD.org/~jhb/ This doesn't make any sense whatsoever. *NOTHING* was using td_ucred until just a few days ago, so unless *you* are blindly changing all p->p_ucred's into td->td_ucred's, I don't see how it can become an issue. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message