Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jan 2014 08:15:21 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r261111 - stable/10/sys/dev/usb/controller
Message-ID:  <201401240815.s0O8FLKA023009@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Fri Jan 24 08:15:21 2014
New Revision: 261111
URL: http://svnweb.freebsd.org/changeset/base/261111

Log:
  MFC r258545:
  Comply to the XHCI specification. Certain input context fields should
  always be zero.

Modified:
  stable/10/sys/dev/usb/controller/xhci.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/usb/controller/xhci.c
==============================================================================
--- stable/10/sys/dev/usb/controller/xhci.c	Fri Jan 24 08:10:08 2014	(r261110)
+++ stable/10/sys/dev/usb/controller/xhci.c	Fri Jan 24 08:15:21 2014	(r261111)
@@ -2614,7 +2614,11 @@ xhci_configure_device(struct usb_device 
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx2, temp);
 
-	temp = XHCI_SCTX_3_DEV_ADDR_SET(udev->address) |
+	/*
+	 * These fields should be initialized to zero, according to
+	 * XHCI section 6.2.2 - slot context:
+	 */
+	temp = XHCI_SCTX_3_DEV_ADDR_SET(0) |
 	    XHCI_SCTX_3_SLOT_STATE_SET(0);
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx3, temp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401240815.s0O8FLKA023009>