From owner-svn-src-projects@freebsd.org  Thu Aug 13 16:40:31 2015
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3897F9B8890
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 13 Aug 2015 16:40:31 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BA1E9DA7;
 Thu, 13 Aug 2015 16:40:30 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t7DGeJcU028833
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 13 Aug 2015 19:40:19 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t7DGeJcU028833
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t7DGeHrL028806;
 Thu, 13 Aug 2015 19:40:17 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 13 Aug 2015 19:40:17 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Baptiste Daroussin <bapt@freebsd.org>
Cc: Bruce Evans <brde@optusnet.com.au>, Bruce Simpson <bms@fastmail.net>,
 Davide Italiano <davide@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 svn-src-projects@freebsd.org
Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef
Message-ID: <20150813164017.GK2072@kib.kiev.ua>
References: <201508082257.t78MvIT1000841@repo.freebsd.org>
 <CACYV=-GnOpPddd-x_J0yW4g4QFsdcEVXaVc9CER9JD7iObGzAg@mail.gmail.com>
 <20150812182739.GB51754@ivaldir.etoilebsd.net>
 <55CB91FD.8000004@fastmail.net>
 <20150813114425.X996@besplex.bde.org>
 <20150813061802.GA62875@ivaldir.etoilebsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150813061802.GA62875@ivaldir.etoilebsd.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2015 16:40:31 -0000

On Thu, Aug 13, 2015 at 08:18:02AM +0200, Baptiste Daroussin wrote:
> FYI the version proposed for tree(3):
> 
> #define RB_COUNT(x, name, head, cnt) do {	\
> 	(cnt) = 0;				\
> 	RB_FOREACH((x), name, (head)) {		\
> 		(cnt)++;			\
> 	}					\
> } while (0)

Please use some local var for count and assign the result to cnt once,
to avoid multiple evaluations for the argument.

Same issue exists for head, but it usually unimportant due to way
the head is used.