Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 May 1999 22:18:51 -0400 (EDT)
From:      Zhihui Zhang <zzhang@cs.binghamton.edu>
To:        freebsd-hackers@freebsd.org
Subject:   VOP_LEASE(...) or (void)VOP_LEASE(...)?
Message-ID:  <Pine.GSO.3.96.990513221012.15708A-100000@sol.cs.binghamton.edu>

next in thread | raw e-mail | index | archive | help

VOP_LEASE(...) always returns 0 so there is no actual need to check its
return value. But still it has a return value.  So should we use
(void)VOP_LEASE(...) instead of just VOP_LEASE(...)? 

BTW, I guess that the practice of modifying
default_vnodeop_p[VOFFSET(vop_lease)] in nfs_init() is a hack. Why do not
we use

   { &vop_lease_desc,              (vop_t *) nqnfs_vop_lease_check }, 

instead of 

   { &vop_lease_desc,              (vop_t *) vop_null },

in nfsv2_vnodeop_entries[] in file nfs_vnops.c?

Thanks for any help.

--------------------------------------------------
Zhihui Zhang.  Please visit http://www.freebsd.org
--------------------------------------------------



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.3.96.990513221012.15708A-100000>