From owner-svn-ports-head@freebsd.org Fri Jun 26 14:26:46 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89CE1358EC3; Fri, 26 Jun 2020 14:26:46 +0000 (UTC) (envelope-from aryeh.friedman@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49tfMp3668z4gqf; Fri, 26 Jun 2020 14:26:46 +0000 (UTC) (envelope-from aryeh.friedman@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id c16so10002088ioi.9; Fri, 26 Jun 2020 07:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bR4/0fbYSnUUVyqiuTATtC/1Hv/0SWuBDvWlEPk4z7g=; b=laYtyMevtoODNl4z2j3E1xbOIMg0aD+JeUu/n5Sp/EvUigJOTIP4YdzNT6YdhPOiNy WVYaKRwrzZcPNY7fb+Wa7vss2QX2am2uErk/koyqJW2ypM8W2KBXT7MnEYJUt7CgbvUE 86TRy7Uj23j4maHSdXEgzJNZS4lneiix5Be6LcrVx4xiLDA0PgvP1K1Ar4J111yvCOXw VVEPUH1K72H81lweVIz72Do0lH6ajPhFNnOP8+KjsA8OXF69xMVb68aOfJ+M1mrUSYE8 6B/S4IsV/ejwf/WYSc2HblhSDQWUG0Jgrj4QVzPW9ptF8NLpqEJE/77nNaXDi2JElBt4 5lrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bR4/0fbYSnUUVyqiuTATtC/1Hv/0SWuBDvWlEPk4z7g=; b=E0B7DLd1xZ0OqYIKAUjNymEOnwJfQchTz9I7h5TVm3FiIYkIQu5x8HewJ7Pnujit5+ byKljWuNatrMmLNdqZemWzyVlJTQNP9Fr5JOGTrRcvapkmWJcYCEkOc7TSw+ilpAIcSR PFItYHyi5m60Z6xV5qmwVW2RtRyp++7MkYKUZi6b0+16Xl02Vw9AV23XIqDREpiguTO4 86HFbY/3/B61IuhVo7tne5x29FmWEnfDl9bTN5BkKIN1bllyM1rm8ViA0KO+ZvCxFFkP J6tTag+cAWLWOvBEeAZTWVDA8GwyWrEk1BL93wrBAKjki6ODUiK6f6vnxjpraVGBliuS C5hQ== X-Gm-Message-State: AOAM533Uv6UyIlpUMEUwAp8lYwxNHybgTXia05BqU9Ol3tH7GQyj2Qux iNVO1mtv27YRYWn3aOD827PhonJvoFmpakp1AkqsCRTl X-Google-Smtp-Source: ABdhPJyfEKVbPz1r3SIzdqujoTK9rG5mS6Q7R9k51QzZw/lL7FVpArDRQGIojqQYZmmBUiN5hTlpgC+D4x5osTnPHrE= X-Received: by 2002:a5d:8e19:: with SMTP id e25mr3783625iod.36.1593181605222; Fri, 26 Jun 2020 07:26:45 -0700 (PDT) MIME-Version: 1.0 References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> <20200626133811.GA60522@FreeBSD.org> <20200626134752.i4ygenf4cc6we6nk@aching.in.mat.cc> <20200626135912.GA82842@FreeBSD.org> <20200626141926.gvbb6xpbxx7aladv@aching.in.mat.cc> In-Reply-To: <20200626141926.gvbb6xpbxx7aladv@aching.in.mat.cc> From: Aryeh Friedman Date: Fri, 26 Jun 2020 10:26:33 -0400 Message-ID: Subject: Re: svn commit: r540489 - in head/devel/fhist: . files To: Mathieu Arnold Cc: Alexey Dokuchaev , "Fernando Apestegu??a" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 49tfMp3668z4gqf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 14:26:46 -0000 On Fri, Jun 26, 2020 at 10:19 AM Mathieu Arnold wrote: > On Fri, Jun 26, 2020 at 01:59:12PM +0000, Alexey Dokuchaev wrote: > > On Fri, Jun 26, 2020 at 03:47:52PM +0200, Mathieu Arnold wrote: > > > Now, the patches in the ports tree need to have a correct and coherent > > > behavior, and fuzzy patching gets it wrong from time to time. This is > > > why range information is not noise, but important metadata that we > > > prefer to be correct all the time. > > > > Well, to your definition of "we". :-) But I get it: you prefer perfect > > patches and noisy commit diffs; I prefer okayish (correctly applicable) > > patches and cleaner commit diffs. > > Well, "we" in that sentence is defined as "ports committers". So you > may want to personnally have patch play russian roulette with the > patches from your ports, but this is not what we want. > > We want patches that apply cleanly, without patch having to randonly > decide where it is going to put the different hunks > As I said in the final patch comment (the one that was finally accepted) that I had remade it completely from scratch and did so using portlint and makepatch and then created the submitted patch file with svn diff. As to the actual functional modification made in the update the port used bison specific functionality and the ports config refused to work with byacc. Additionally the port used an implicit api.prefix in its grammar (depreciated in bison 3.6.X and removed in 3.6.4) so I added the needed code to make the api.prefix explicit. All the above procedures were done as per various feedback from commiters. So the short version is while yes the port is slightly non-standard the patch is not (as far I was lead to believe). -- Aryeh M. Friedman, Lead Developer, http://www.PetiteCloud.org