From owner-svn-src-head@freebsd.org  Mon Jan 22 19:24:46 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3DA2ED1365;
 Mon, 22 Jan 2018 19:24:45 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id B77906A227;
 Mon, 22 Jan 2018 19:24:45 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.55.3])
 by phk.freebsd.dk (Postfix) with ESMTP id D22A727395;
 Mon, 22 Jan 2018 19:24:43 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w0MJORTB089104
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 22 Jan 2018 19:24:28 GMT (envelope-from phk@critter.freebsd.dk)
Received: (from phk@localhost)
 by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w0MJORtl089103;
 Mon, 22 Jan 2018 19:24:27 GMT (envelope-from phk)
To: John Baldwin <jhb@freebsd.org>
cc: Emmanuel Vadot <manu@bidouilliste.com>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm
 modules
In-reply-to: <52374125.OgxafgljNu@ralph.baldwin.cx>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <201801220710.w0M7AUm9091853@repo.freebsd.org>
 <88258.1516630050@critter.freebsd.dk>
 <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com>
 <52374125.OgxafgljNu@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89101.1516649067.1@critter.freebsd.dk>
Date: Mon, 22 Jan 2018 19:24:27 +0000
Message-ID: <89102.1516649067@critter.freebsd.dk>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 19:24:46 -0000

--------
In message <52374125.OgxafgljNu@ralph.baldwin.cx>, John Baldwin writes:

>Create the corresponding device_t but device_disable() it when there
>is a disabled property.

That also removes a couple of boilerplate lines from all FDT device
drivers.

>A user can then use 'devctl enable <blah>' to enable
>it before (or even after) loading a device driver.

That would work for me.

I wonder if it would be too noisy if we allowed ->probe() to run
on disabled devices and reported something like:

	"foobar0: Matched disabled device <...>"

(without calling ->attach())

That way you would know you loaded the right driver, rather
than have to guess.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.