From owner-freebsd-current@FreeBSD.ORG  Wed Feb 21 22:08:18 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8475216A402
	for <current@freebsd.org>; Wed, 21 Feb 2007 22:08:18 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (palm.hoeg.nl [83.98.131.212])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B5F913C442
	for <current@freebsd.org>; Wed, 21 Feb 2007 22:08:18 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id F068B1CE1B; Wed, 21 Feb 2007 22:36:19 +0100 (CET)
Date: Wed, 21 Feb 2007 22:36:19 +0100
From: Ed Schouten <ed@fxq.nl>
To: Josef Karthauser <joe@tao.org.uk>
Message-ID: <20070221213619.GB834@hoeg.nl>
References: <20070221171816.GB2202@genius.tao.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx"
Content-Disposition: inline
In-Reply-To: <20070221171816.GB2202@genius.tao.org.uk>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-Mailman-Approved-At: Wed, 21 Feb 2007 22:33:01 +0000
Cc: current@freebsd.org
Subject: Re: Zombie Jails - why don't they disappear?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Feb 2007 22:08:18 -0000


--zYM0uCDKw75PZbzx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Josef Karthauser <joe@tao.org.uk> wrote:
> Any ideas why they are still hanging around in the jail list?

The problem is quite complex:

- pty's aren't deallocated in the kernel anymore
- because pty device nodes cannot be deallocated before it has no
  process groups bound to it, pty's wouldn't even be deallocated in a
  lot of situations (kill sshd).

The easiest fix would be to replace the make_dev_cred() call in
tty_pty.c with make_dev(). This should at least solve the jail leak.

--=20
 Ed Schouten <ed@fxq.nl>
 WWW: http://g-rave.nl/

--zYM0uCDKw75PZbzx
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFF3LtT52SDGA2eCwURAt6GAJ9fwh/eh7/UXw/t6pwCK09JujgnpQCeOESH
NE3mnKsoqspCQn86+YxNFPo=
=701o
-----END PGP SIGNATURE-----

--zYM0uCDKw75PZbzx--