From owner-cvs-all  Mon Aug 13 16:54:49 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7F8F837B401; Mon, 13 Aug 2001 16:54:42 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: from laptop.baldwin.cx (john@[147.11.46.201])
	by mail.wrs.com (8.9.3/8.9.1) with ESMTP id QAA12048;
	Mon, 13 Aug 2001 16:54:39 -0700 (PDT)
Message-ID: <XFMail.010813165443.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010814091732.A8344-100000@besplex.bde.org>
Date: Mon, 13 Aug 2001 16:54:43 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Subject: RE: cvs commit: src/sys/i386/i386 machdep.c
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Bruce Evans <bde@FreeBSD.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 13-Aug-01 Bruce Evans wrote:
> On Mon, 13 Aug 2001, John Baldwin wrote:
> 
>> On 13-Aug-01 Bruce Evans wrote:
>> > bde         2001/08/13 06:22:50 PDT
>> >
>> >   Modified files:
>> >     sys/i386/i386        machdep.c
>> >   Log:
>> >   Use interrupt gates instead of trap gates for breakpoint and trace
>> >   traps, so that ddb can keep control (almost) no matter how it is
>> >   entered.  ...
> 
>> I take it the disabling of interrupts in Debugger() can be axed now?
> 
> Yes.  Also in i386-gdbstub.c.
> 
> The anti-reentrancy flag in Debugger() can probably be axed too.  It
> is similarly half-baked and is now unnecessary for preventing reentrance
> via the keyboard interrupt handler.

What if we hit a code path from the Debugger that calls the Debugger() function?
Esp. since we can call any function from ddb if we really want to...

I suppose we could use db_active to test for this?  But that is ddb-specific..

> Bruce

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message