From owner-freebsd-stable@FreeBSD.ORG Thu Oct 28 16:31:21 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A660A1065693 for ; Thu, 28 Oct 2010 16:31:21 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 450A48FC28 for ; Thu, 28 Oct 2010 16:31:20 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id E095A45CAC; Thu, 28 Oct 2010 18:31:18 +0200 (CEST) Received: from localhost (chello089073192049.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id C1A1F45685; Thu, 28 Oct 2010 18:31:12 +0200 (CEST) Date: Thu, 28 Oct 2010 18:30:36 +0200 From: Pawel Jakub Dawidek To: Mikolaj Golub Message-ID: <20101028163036.GA2347@garage.freebsd.pl> References: <86wrp3wj67.fsf@kopusha.home.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <86wrp3wj67.fsf@kopusha.home.net> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-stable@freebsd.org, Pete French Subject: Re: hast vs ggate+gmirror sychrnoisation speed X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 16:31:21 -0000 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2010 at 10:05:20PM +0300, Mikolaj Golub wrote: > In hast_proto_send() we send header and then data. Couldn't it be that > remote_send and sync threads interfere and their packets are mixed? May b= e some > synchronization is needed here? >=20 > I set sleep(1) in hast_proto_send() between proto_send(header) and > proto_send(data). The error started to occur frequently. Synchronization requests are sent through the remote thread just like regular I/O requests, exactly because of races that can occur. I looked at the code and the keepalive packets arbe sent from another thread. Could you try turning them off in primary.c and see if that helps? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkzJpSwACgkQForvXbEpPzSqfwCdEOoi4BV1Iu0NiRrybQvnrdKG rU8AoLZfOONZqaiXOSBdUO5XP9bWEOMi =B6zi -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--