From owner-svn-src-projects@FreeBSD.ORG Fri Dec 12 06:01:10 2008 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56C2B1065673; Fri, 12 Dec 2008 06:01:10 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 469A08FC14; Fri, 12 Dec 2008 06:01:10 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mBC61AjO088303; Fri, 12 Dec 2008 06:01:10 GMT (envelope-from sam@svn.freebsd.org) Received: (from sam@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mBC61AOp088302; Fri, 12 Dec 2008 06:01:10 GMT (envelope-from sam@svn.freebsd.org) Message-Id: <200812120601.mBC61AOp088302@svn.freebsd.org> From: Sam Leffler Date: Fri, 12 Dec 2008 06:01:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r185973 - projects/arpv2_merge_1/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Dec 2008 06:01:10 -0000 Author: sam Date: Fri Dec 12 06:01:09 2008 New Revision: 185973 URL: http://svn.freebsd.org/changeset/base/185973 Log: o fix comments o gratuitous style change Modified: projects/arpv2_merge_1/sys/net/if_llatbl.c Modified: projects/arpv2_merge_1/sys/net/if_llatbl.c ============================================================================== --- projects/arpv2_merge_1/sys/net/if_llatbl.c Fri Dec 12 06:00:15 2008 (r185972) +++ projects/arpv2_merge_1/sys/net/if_llatbl.c Fri Dec 12 06:01:09 2008 (r185973) @@ -237,10 +237,7 @@ lla_rt_output(struct rt_msghdr *rtm, str return EINVAL; /* XXX not implemented yet */ } - /* - * XXXXXXXX: - * REVISE this approach if possible. - */ + /* XXX linked list may be too expensive */ IFNET_RLOCK(); SLIST_FOREACH(llt, &lltables, llt_link) { if (llt->llt_af == dst->sa_family && @@ -258,9 +255,10 @@ lla_rt_output(struct rt_msghdr *rtm, str IF_AFDATA_UNLOCK(ifp); if (lle != NULL) { if (flags & LLE_CREATE) { - /* qing: if we delay the delete, then if a subsequent - * "arp add" on the same host should look up this entry, - * reset the LLE_DELETED flag, and reset the expiration timer + /* + * If we delay the delete, then a subsequent + * "arp add" should look up this entry, reset the + * LLE_DELETED flag, and reset the expiration timer */ bcopy(LLADDR(dl), &lle->ll_addr, ifp->if_addrlen); lle->la_flags |= LLE_VALID; @@ -273,7 +271,7 @@ lla_rt_output(struct rt_msghdr *rtm, str lle->ln_state = ND6_LLINFO_REACHABLE; #endif /* - * "arp" and "ndp" always sets the (RTF_STATIC | RTF_HOST) flags + * NB: arp and ndp always set (RTF_STATIC | RTF_HOST) */ if (rtm->rtm_rmx.rmx_expire == 0) { @@ -285,8 +283,7 @@ lla_rt_output(struct rt_msghdr *rtm, str LLE_WUNLOCK(lle); #ifdef INET /* gratuious ARP */ - if ((laflags & LLE_PUB) && - dst->sa_family == AF_INET) { + if ((laflags & LLE_PUB) && dst->sa_family == AF_INET) { arprequest(ifp, &((struct sockaddr_in *)dst)->sin_addr, &((struct sockaddr_in *)dst)->sin_addr,