From owner-freebsd-testing@FreeBSD.ORG Tue Oct 15 03:25:08 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 97E6C814 for ; Tue, 15 Oct 2013 03:25:08 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 224202B71 for ; Tue, 15 Oct 2013 03:25:07 +0000 (UTC) Received: by mail-lb0-f177.google.com with SMTP id w7so6161847lbi.8 for ; Mon, 14 Oct 2013 20:24:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Lii09pDL2WZbDPwi30+SjwRVdUm+poo+opQ9vO4AXhc=; b=Co09aKt6JoG/3D2+DrJL7aZhDnhvX3tcNIuYB2NQO/8ewC23duw3i/BxDiC9QKuNJ2 Y8+d1i1RZBbZzjStlT+dILnhCmsr5Fwoe1u/CHrNNf/3LdZaRKqRiLKLS7s9AWqF067r 6+Adc/dvEfbCupAQDxgHtXJCpARTRFwZEwMPmhyBw9vS2XFx958S41yoB/joSkKhAw8P BYIMsdw4zvItbL6KzTfAPECoE9yXKPo9gRKblHGhD/V8T7nbSwuUzmlWj2U90GrH5pFV Y3ctCc9dsmHr028BteMMKsMMtXeECWc8Ctjn04jf8boApiZU1MucVDOAYFOtqVo4y0WP KfKw== X-Gm-Message-State: ALoCoQnr0PRrjEtoDN0X5bRtipOnzhhpcvGSferXqJKNsXkEKwGvRvWcn1gXlikrKtfRS0r97PLQ X-Received: by 10.112.42.68 with SMTP id m4mr33569266lbl.4.1381807499694; Mon, 14 Oct 2013 20:24:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Mon, 14 Oct 2013 20:24:39 -0700 (PDT) X-Originating-IP: [108.176.158.82] In-Reply-To: References: From: Julio Merino Date: Mon, 14 Oct 2013 23:24:39 -0400 Message-ID: Subject: Re: Refactoring of *.test.mk To: freebsd-testing@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Rui Paulo , Garrett Cooper , Simon Gerraty X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 03:25:08 -0000 [Fixing Garrett's address...] On Mon, Oct 14, 2013 at 10:44 PM, Julio Merino wrote: > Hello all, > > [ CCing a few people directly that are probably interested. ] > > After the recent removal of the deprecated ATF tools from the tree, I > have been working on a refactoring of the FreeBSD *.test.mk Makefiles > to add various features that spilled from that change. > > The highlights of this work so far: > > - Clearly documented the interface of each *.test.mk file by putting > the list of public variables at the top and adding comments where due. > > - Split the logic to build framework-less test programs into a new > plain.test.mk file. This is in accordance with atf.test.mk, but also > helps clarifying the code, defining a proper interfac in bsd.test.mk > and makes some of the other changes simpler. > > - Added support to generate both Atffile and Kyuafile files. > > - Added support to run the tests using both atf-run and kyua (from ports). > > You can find the relevant patches in: > http://portal.meroh.net/~jmmv/freebsd-testing/ . > > The patches have been generated using quilt so take a look at the > contents of the 'series' file to see in which order they would need to > be applied. > > Each patch has a description at the top which can later be used as the > commit log. > > Note that, at the moment, this can only be exercised in > lib/libcrypt/tests/ . I actually wanted to write some tests for > *.test.mk themselves (!) but I wouldn't want to spend time on that > before agreeing that this structure is sensible. If it is, I might put > the effort ;-) See the ones here > http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/share/mk/?only_with_tag=MAIN > to get an idea of what they could look like. > > Anybody up for reviewing these patches and sharing their comments? > > Thanks! > > -- > Julio Merino / @jmmv -- Julio Merino / @jmmv