From nobody Fri Oct 4 15:57:52 2024 X-Original-To: geom@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XKtVS5Vc3z5Xy7P for ; Fri, 04 Oct 2024 15:57:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XKtVS47Nqz43Y0 for ; Fri, 4 Oct 2024 15:57:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728057472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tci0mj03BerxZFqyBZEAC6xECbWMmvC6U+JLJSHDRZk=; b=Wb5k/s+JRBGh23DvVXJKeWTMnCvhD0xsvpEhoHzuyfVfN26tpX85Zn+676vAQ8zOU0S5DF Flyi3UUtIpSHVXw4v+WpKrCqeVRhHH83f02MxlIjZns/siIFGYjHaGoSrV9KhR/H+YirQ2 t454QPFDXc/bA/kOVQqy9p4i5+4Wfwur3oLJNn8dTcuqcwsYjAsLhU+ThrZs2puqpb+GqU GbOXX2pvxIXdWQGaE/tfVeuJT/x/rIxBBW+uoLlLYRuDTdmR7UgKhp2PoczFe7wq+K4Avy 4tw3/FqvAELIKn3/pl/R9LmPvkHCqWwfILruEwo34ZwoDRbQj8h+2wBOtYylaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728057472; a=rsa-sha256; cv=none; b=Nfa959TfpzBlwwYsoWAiMtzyBp0b+XRNJQpSks1sZ9T+rjD9Qo6dTa9JRcXpw3gpMEJIo4 bzkkCiH4aff0KdvnzJl9zmlFYKkeIh6Ij7hns9mxjHCxpIeR1a+MTOhI77csId88trgMIb aUVQnFYg8Pb6vGR3Mk/utdx64T3l4vfzNGUdSJDiSJPxs9mtxXg81z67GqDtQE2lMjH8JI rwxTHn4acpGeD9JyIKrfzBW/9VwDzun7tRJwK+aOQKv8vkr6Ogw44Ow3SIhGB/QgWjW81J 115BsWmJswVzOiYcgrY46hw1gWz5uxTdlHKEwunGUDOAIEuFq2MP89tIfTdaTQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XKtVS3d8dzh1W for ; Fri, 4 Oct 2024 15:57:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 494Fvq2w098827 for ; Fri, 4 Oct 2024 15:57:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 494FvqTV098826 for geom@FreeBSD.org; Fri, 4 Oct 2024 15:57:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: geom@FreeBSD.org Subject: [Bug 238814] geom: topology lock being dropped in dumpconf of gate, raid, & raid3 Date: Fri, 04 Oct 2024 15:57:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: geom@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GEOM-specific discussions and implementations List-Archive: https://lists.freebsd.org/archives/freebsd-geom List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-geom@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238814 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db37b2543a23b44c78f6d78823dcfcedba= 46570db commit b37b2543a23b44c78f6d78823dcfcedba46570db Author: Mark Johnston AuthorDate: 2024-10-04 14:53:57 +0000 Commit: Mark Johnston CommitDate: 2024-10-04 15:56:34 +0000 ggate: Avoid dropping the GEOM topology lock in dumpconf In general it's not safe to drop the topology lock in these routines, as GEOM assumes that the mesh will be consistent during traversal. However, there's no reason we can't hold the topology lock across calls to g_gate_release(). (Note that g_gate_hold() can be called with the topology lock held.) PR: 238814 MFC after: 2 weeks sys/geom/gate/g_gate.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=