From owner-freebsd-current@FreeBSD.ORG Tue Jul 31 03:54:00 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDD4E16A418; Tue, 31 Jul 2007 03:54:00 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from ns.trinitel.com (186.161.36.72.static.reverse.layeredtech.com [72.36.161.186]) by mx1.freebsd.org (Postfix) with ESMTP id A0FC113C459; Tue, 31 Jul 2007 03:54:00 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from proton.local (r74-193-81-203.pfvlcmta01.grtntx.tl.dh.suddenlink.net [74.193.81.203]) (authenticated bits=0) by ns.trinitel.com (8.14.1/8.14.1) with ESMTP id l6V3ruGH061791; Mon, 30 Jul 2007 22:53:56 -0500 (CDT) (envelope-from anderson@freebsd.org) Message-ID: <46AEB24E.7090504@freebsd.org> Date: Mon, 30 Jul 2007 22:53:50 -0500 From: Eric Anderson User-Agent: Thunderbird 2.0.0.5 (Macintosh/20070716) MIME-Version: 1.0 To: Oleg Bulyzhin References: <46A2B49F.4030307@freebsd.org> <20070722155356.49797993@roxette> <46A36A49.2090303@FreeBSD.org> <20070723081949.GA1528@lath.rinet.ru> In-Reply-To: <20070723081949.GA1528@lath.rinet.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on ns.trinitel.com Cc: Attilio Rao , Patrick Lamaiziere , freebsd-current@freebsd.org Subject: Re: LOR's, and a panic (ipf NAT related?) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2007 03:54:00 -0000 Oleg Bulyzhin wrote: > On Sun, Jul 22, 2007 at 04:31:37PM +0200, Attilio Rao wrote: >> Patrick Lamaiziere wrote: >>> Le Sat, 21 Jul 2007 20:36:31 -0500, >>> Eric Anderson a ?crit : >>>> Today, on a -CURRENT from a few days ago (running ULE 3.0), I got a >>>> panic: >>>> >>>> panic: Trying sleep, but thread marked as sleeping prohibited >>>> cpuid = 0 >>>> >> This one should have been fixed in last ULE3.0 revision, could you please >> update your src/sys and see if it goes away? >> >> About the other LORs, you should see in the bz's page if they are alredy >> listes, since it seems I remind at least one of them: >> http://sources.zabbadoz.net/freebsd/lor.html >> >> >> Thanks, >> Attilio >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > This panic is not ULE related. It came from wrong sx lock usage inside ipfilter. > I tried to use recently imported (into -current) ipfilter 4.1.23 and found it > is almost unusable (at least ipnat): it's very unstable (several hangs or > deadlocks per day), it does leak memory. > > I've spent some time on fixing ipfilter's bugs, then sent report to ipfilter's > author. Unfortunately, i failed to get any feedback. > > You can get patch here: > http://people.freebsd.org/~oleg/patches/ipfilter.r70.diff > > I would not swear it's 100% correct, but it should make ipfilter much more > stable. It does following: > - sx locks converted to rwlocks. (this should be done, cause pfil(4) uses > rwlocks, which are not sleepable). > - fixed memory leak inside nat_getnext() > - fixed several improper checks of array's boundary. > - added some missing mutex_destroy() calls > - ipfilter's attaching/detaching procedure changed a bit in order to fix some > LORs. > Lost track of this - did it ever get ironed out? Eric