From owner-svn-ports-head@FreeBSD.ORG  Mon Jun 24 11:52:03 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 14B8A5C3;
 Mon, 24 Jun 2013 11:52:03 +0000 (UTC)
 (envelope-from william88@gmail.com)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com
 [IPv6:2a00:1450:4010:c04::22d])
 by mx1.freebsd.org (Postfix) with ESMTP id CCB7511C9;
 Mon, 24 Jun 2013 11:52:01 +0000 (UTC)
Received: by mail-lb0-f173.google.com with SMTP id v1so427701lbd.32
 for <multiple recipients>; Mon, 24 Jun 2013 04:52:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=G4yhjj0fO3YycWNmAWIIY96zV618SKNl9oDViwt7BsY=;
 b=VjZh6Hobx0pQaRtlXORqgchv2eUP8COETDgBYGMFT3DG4ZSnffn+osDYQCGn4ubZUZ
 hFs31gDzgr1yItJmA8S3XqsxVhMuQ/Ih105YjvCMq7PCfN2Qz+ickj8wbPFUWLqYdB2y
 KWCu1eS7OLerbQnAck1yKYaBd0B4QdetszRUcR37HU1J7YfOTDH0w55LmKId6i1kMaBJ
 cHcEPTVWWWDb3MDDcenRu74xM5YaF6C3ekd+qAo6KSXZ4oMqH565YkULVzaOBfdk1ISa
 z7cRT1ITyKKb+G+A2IyUHk4JFTN8Eaj50MBq+gfKLUEqK5Eruvam8WFrnfUb/hTB+Jr0
 WPAg==
MIME-Version: 1.0
X-Received: by 10.152.8.103 with SMTP id q7mr11299261laa.64.1372074720714;
 Mon, 24 Jun 2013 04:52:00 -0700 (PDT)
Received: by 10.114.172.116 with HTTP; Mon, 24 Jun 2013 04:52:00 -0700 (PDT)
In-Reply-To: <20130624114320.GA74688@FreeBSD.org>
References: <201306241119.r5OBJ3GV045211@svn.freebsd.org>
 <20130624114320.GA74688@FreeBSD.org>
Date: Mon, 24 Jun 2013 08:52:00 -0300
Message-ID: <CAHtVNLOL8Y7hi6aoxAm=BcEUbLkqo1igQDJmjA+Dq=zLmJ-nNQ@mail.gmail.com>
Subject: Re: svn commit: r321675 - in head/net-mgmt/netdisco: . files
From: William Grzybowski <william88@gmail.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 William Grzybowski <wg@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2013 11:52:03 -0000

On Mon, Jun 24, 2013 at 8:43 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Mon, Jun 24, 2013 at 11:19:03AM +0000, William Grzybowski wrote:
>> New Revision: 321675
>> URL: http://svnweb.freebsd.org/changeset/ports/321675
>>
>> +OPTIONS_DEFINE=      DOCS GRAPHVIZ MIBS
>> +OPTIONS_DEFAULT=DOCS GRAPHVIZ MIBS
>
> DOCS option (and a few more) is already on by default, there's no need to
> relist it here.
>
>> -DOCS=                doc/*.pod doc/*.html INSTALL README* UPGRADE
>> +DOCFILES=    ChangeLog doc/*.pod INSTALL README* UPGRADE
>
> It would probably makes sense to do smth. like this:
>
> DOCFILES=       ChangeLog doc/*.pod INSTALL README* UPGRADE
> PORTDOCS=       *
>
> post-install:
> .if ${PORT_OPTIONS:MDOCS}
>         ${MKDIR} ${DOCSDIR}
>         (cd ${WRKSRC} && ${INSTALL_DATA} ${DOCFILES} ${DOCSDIR})
> .endif
>
> And remove entries from pkg-plist.
>
>>       @${CAT} ${PKGMESSAGE}
>
> It's benefitial to surround cat(1) here with @${ECHO_MSG}'s to ensure that
> pkg-message is printed with consistent padding (port vs. package install).
>
> ./danfe

Thank you!

--
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil