Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Feb 2011 16:35:42 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Garrett Cooper <gcooper@freebsd.org>
Cc:        svn-src-head@freebsd.org, Roman Divacky <rdivacky@freebsd.org>, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>, svn-src-all@freebsd.org
Subject:   Re: svn commit: r218716 - head/sys/boot/common
Message-ID:  <201102151635.42232.jhb@freebsd.org>
In-Reply-To: <AANLkTinfg1GCsk5w%2BZTvqcuE0021ox%2ByQoKiTti5c0YL@mail.gmail.com>
References:  <201102152101.p1FL1D5Z044262@svn.freebsd.org> <20110215210817.GA64113@freebsd.org> <AANLkTinfg1GCsk5w%2BZTvqcuE0021ox%2ByQoKiTti5c0YL@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, February 15, 2011 4:18:41 pm Garrett Cooper wrote:
> On Tue, Feb 15, 2011 at 1:08 PM, Roman Divacky <rdivacky@freebsd.org> wrote:
> > I put there u_int8_t for a reason. That reason being that
> > it's basically struct direct->d_type which is u_int8_t
> > and not uint8_t.
> 
>     Even though they're technically the same typedef'ed type (I'd keep
> style consistent according to the argument rdivacky is making). I
> guess this has about the same bikeshed-ability as my proposal to
> change all of the *chflags syscalls to use fflags_t instead of
> u_long/int/etc on freebsd-fs did a few weeks back.

No, this is different.  The uint8_t is correct.  C99 adopted uint*_t making 
u_int*_t deprecated.  In general all new code should use the C99 types.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102151635.42232.jhb>