From owner-svn-src-all@FreeBSD.ORG Tue Feb 15 21:35:44 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10E53106566C; Tue, 15 Feb 2011 21:35:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D58458FC13; Tue, 15 Feb 2011 21:35:43 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9079946B37; Tue, 15 Feb 2011 16:35:43 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.10]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B6DAC8A009; Tue, 15 Feb 2011 16:35:42 -0500 (EST) From: John Baldwin To: Garrett Cooper Date: Tue, 15 Feb 2011 16:35:42 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201102152101.p1FL1D5Z044262@svn.freebsd.org> <20110215210817.GA64113@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102151635.42232.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 15 Feb 2011 16:35:42 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=0.5 required=4.2 tests=BAYES_00,MAY_BE_FORGED, RDNS_DYNAMIC autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, Roman Divacky , src-committers@freebsd.org, Dimitry Andric , svn-src-all@freebsd.org Subject: Re: svn commit: r218716 - head/sys/boot/common X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2011 21:35:44 -0000 On Tuesday, February 15, 2011 4:18:41 pm Garrett Cooper wrote: > On Tue, Feb 15, 2011 at 1:08 PM, Roman Divacky wrote: > > I put there u_int8_t for a reason. That reason being that > > it's basically struct direct->d_type which is u_int8_t > > and not uint8_t. > > Even though they're technically the same typedef'ed type (I'd keep > style consistent according to the argument rdivacky is making). I > guess this has about the same bikeshed-ability as my proposal to > change all of the *chflags syscalls to use fflags_t instead of > u_long/int/etc on freebsd-fs did a few weeks back. No, this is different. The uint8_t is correct. C99 adopted uint*_t making u_int*_t deprecated. In general all new code should use the C99 types. -- John Baldwin