From nobody Tue Jan 20 16:05:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dwXH71N3Yz6PkvQ for ; Tue, 20 Jan 2026 16:05:39 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dwXH65swmz3GDS for ; Tue, 20 Jan 2026 16:05:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42fbc544b09so3563305f8f.1 for ; Tue, 20 Jan 2026 08:05:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768925132; x=1769529932; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BBmtJeB9tD5sAXnop96+jO2ZhO/fw7awIyAxIM5nKa0=; b=nBdg0RaDVTSFiofbr5BUCQ3Kf0IypLWJg/K3N64OAtCv1g6HarhFyZ9EkXqSU5MdY6 GcXOiweJxdcloKV1Y9fGhxh4kGvI6oC+lCcBu0pMclwcG3kx3QvL1qzpTHhNCW6WQX1X cHTKgetgDSkxzX8i3xor2fFTFbkRW/c0bzoIzvZDhkF7Jyaat6Bf9+vnEh935y8ZXRAw j9Rtkvnl3qfXxrfUOGNK8gkxdHQSAd17q9Vdywsed9uv679T51I9VKkzvoK2CCm4lfPl O6DigdL3CaWUjDbY9WmtXomT9EN5fV2rjl5t7EgHIMHElFfrWCWHqSxqKMk4/90ZOfaQ TFqw== X-Forwarded-Encrypted: i=1; AJvYcCXOFOjGuFyxBOIP7JxXflb5ouAS4acC2k5L58mlIL2hlmeX2sDLfIvyKbb0LXTguVZtOhDW1R9ZvyLZJPjRhNJxvLa8@freebsd.org X-Gm-Message-State: AOJu0YyVEv8VnKGXWGuiMxDfl7TDD0VAy1VvMIDaIF73sFt1vHolmokX BbPfxq0AA20e406+Ax5xfXdd38FM3eFXYMBYXB7jogqTr44m9I9TunoMsvZA0olGF10= X-Gm-Gg: AZuq6aJUFMe2l4QzHgWVkJ5iiNQvLwf5RXwG3Byi5TFeJ5WlcVUkmY8QUwTS+6BpDFe +z845E5nuJOqjqMqQ2OmkjXKZwyzjghQglJUHdqPuNxSOjlQZRGzlCKKywj7YSp2Lff32k8MCUB mXOTXD7tD5Qk5+k+R5AdUh7q9PeCaONKCJkqJBbMRamBcdUCZy5Rrtj84zbHR2ksG8ZphGWj9UB sHwKvX3GLHiGQ2xCb0ODjUBm5f9d+hQlE5Q0SG3Z9CAiBcKP5ChqQ51KvrZnlHTXXd8KAVR6wu3 76hTYgrw5Bq6DbXmvLyA+Wxr3B/GDxCnaBStNaLW7eOI4XAGID7TPjSYNqTbpksba/LbAHqC5Bi +clxSwOOyB42CvshWXsYQhzMqZOKl9el+EDo3MoDIp0PB16dsUgNkZWHu6PnHdmj5g4xeSeCRFm 7z2iCwv4tXJZAL4TgdV3FEdAbg9olPTiDnBKa6Il/733PdMCieI0vS X-Received: by 2002:a05:6000:4210:b0:430:f68f:ee96 with SMTP id ffacd0b85a97d-4358ff56807mr3854083f8f.36.1768925130893; Tue, 20 Jan 2026 08:05:30 -0800 (PST) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43595e0a6fasm1956494f8f.10.2026.01.20.08.05.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2026 08:05:30 -0800 (PST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: git: 96acaa960023 - main - compat32: provide a type and a macro for (u)int64_t handling on non-x86 arches From: Jessica Clarke In-Reply-To: <696f9463.f398.7ea9495a@gitrepo.freebsd.org> Date: Tue, 20 Jan 2026 16:05:19 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7F0190E5-8B20-40A5-9D31-1D56BCF39E71@freebsd.org> References: <696f9463.f398.7ea9495a@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3864.300.41.1.7) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dwXH65swmz3GDS On 20 Jan 2026, at 14:42, Konstantin Belousov wrote: >=20 > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D96acaa960023c20e852e04e7cc5c6a5f= aca36c67 >=20 > commit 96acaa960023c20e852e04e7cc5c6a5faca36c67 > Author: Konstantin Belousov > AuthorDate: 2026-01-12 04:45:36 +0000 > Commit: Konstantin Belousov > CommitDate: 2026-01-20 14:42:35 +0000 >=20 > compat32: provide a type and a macro for (u)int64_t handling on = non-x86 arches >=20 > uint64_t is 4-byte aligned on i386, but is 8-bytes aligned on all = other > 32bit arches FreeBSD supports. Provide the freebsd32_uint64_t type = and > the FU64_CP() macro, which are intended to be used where 32bit ABI = uses > (u)int64_t type, and do proper layout and copying for the aggregate = type. >=20 > Reviewed by: des, emaste > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D54663 > --- > sys/compat/freebsd32/freebsd32.h | 11 ++++++++++- > sys/sys/abi_compat.h | 8 ++++++++ > 2 files changed, 18 insertions(+), 1 deletion(-) >=20 > diff --git a/sys/compat/freebsd32/freebsd32.h = b/sys/compat/freebsd32/freebsd32.h > index 9d724c93fee7..7324f9adf70c 100644 > --- a/sys/compat/freebsd32/freebsd32.h > +++ b/sys/compat/freebsd32/freebsd32.h > @@ -36,8 +36,17 @@ > #include >=20 > /* > - * i386 is the only arch with a 32-bit time_t > + * i386 is the only arch with a 32-bit time_t. > + * Also it is the only arch with (u)int64_t having 4-bytes alignment. > */ > +typedef struct { > +#ifdef __amd64__ > + uint32_t val[2]; > +#else > + uint64_t val; > +#endif > +} freebsd32_uint64_t; Any reason not to use: typedef uint64_t freebsd32_uint64_t __aligned(4); on amd64 (and normal typedef elsewhere)? Then you can just use the normal CP. See for example https://godbolt.org/z/svseWv7xo. Jessica