From owner-cvs-all@FreeBSD.ORG Mon Dec 27 22:11:08 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E24D16A4CF for ; Mon, 27 Dec 2004 22:11:08 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 833F243D48 for ; Mon, 27 Dec 2004 22:11:07 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 5802 invoked from network); 27 Dec 2004 22:11:07 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 27 Dec 2004 22:11:06 -0000 Received: from [10.50.41.243] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iBRMArTM089244; Mon, 27 Dec 2004 17:11:04 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: rwatson@FreeBSD.org Date: Mon, 27 Dec 2004 16:00:26 -0500 User-Agent: KMail/1.6.2 References: <200412262252.iBQMqPe7060613@repoman.freebsd.org> <20041227005456.GA57720@xor.obsecurity.org> In-Reply-To: <20041227005456.GA57720@xor.obsecurity.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200412271600.26989.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2004 22:11:08 -0000 On Sunday 26 December 2004 07:54 pm, Kris Kennaway wrote: > On Sun, Dec 26, 2004 at 10:52:24PM +0000, Robert Watson wrote: > > rwatson 2004-12-26 22:52:24 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_witness.c > > Log: > > Add "show alllocks" command to DDB, which dumps a list of processes > > and threads currently holding sleep mutexes (and spin mutexes for > > curthread). This can be quite useful in looking for a lock condition > > summary for a system, as it avoids manually iterating through threads > > and processes to find all the interesting locks. > > > > NB: "alllocks" is up there with "lockedvnods" for a bad argument for > > show. > > ITYM "allloks" or perhaps "alllockes" (conservation of vowels). If you want a better name you could do 'show locks /a' instead. That is, add support to 'show locks' for the /a option (see 'show ktr' for how you would handle this by looking at 'modif'). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org