From owner-freebsd-hackers@FreeBSD.ORG Wed Aug 14 02:02:36 2013 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5E1ABC68; Wed, 14 Aug 2013 02:02:36 +0000 (UTC) (envelope-from prvs=19381d5a45=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 672C825B8; Wed, 14 Aug 2013 02:02:35 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50005485496.msg; Wed, 14 Aug 2013 03:02:32 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Wed, 14 Aug 2013 03:02:32 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=19381d5a45=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: "Richard Yao" , References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 Date: Wed, 14 Aug 2013 03:02:49 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: Richard Yao , Eitan Adler X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 02:02:36 -0000 Could you provide the output from camcontrol identify for these disks I want to just double check the formatting before commiting as I don't have these disks here in labs. Regards Steve ----- Original Message ----- From: "Richard Yao" To: Cc: "Richard Yao" ; "Eitan Adler" Sent: Sunday, August 11, 2013 1:12 PM Subject: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 > Signed-off-by: Richard Yao > --- > sys/cam/ata/ata_da.c | 24 ++++++++++++++++++++++++ > sys/cam/scsi/scsi_da.c | 24 ++++++++++++++++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c > index f201231..b7f293d 100644 > --- a/sys/cam/ata/ata_da.c > +++ b/sys/cam/ata/ata_da.c > @@ -349,6 +349,14 @@ static struct ada_quirk_entry ada_quirk_table[] = > }, > { > /* > + * Intel X25-M Series SSDs > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > * Kingston E100 Series SSDs > * 4k optimised & trim only works in 4k requests + 4k aligned > */ > @@ -365,6 +373,22 @@ static struct ada_quirk_entry ada_quirk_table[] = > }, > { > /* > + * Marvell SSD (entry taken from Open Solaris) > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > + * OCZ Agility 2 SSDs > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > * OCZ Agility 3 SSDs > * 4k optimised & trim only works in 4k requests + 4k aligned > */ > diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c > index 617afbd..df895be 100644 > --- a/sys/cam/scsi/scsi_da.c > +++ b/sys/cam/scsi/scsi_da.c > @@ -1008,6 +1008,14 @@ static struct da_quirk_entry da_quirk_table[] = > }, > { > /* > + * Intel X25-M Series SSDs > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > * Kingston E100 Series SSDs > * 4k optimised & trim only works in 4k requests + 4k aligned > */ > @@ -1024,6 +1032,22 @@ static struct da_quirk_entry da_quirk_table[] = > }, > { > /* > + * Marvell SSD (entry taken from Open Solaris) > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > + * OCZ Agility 2 SSDs > + * 4k optimised & trim only works in 4k requests + 4k aligned > + */ > + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, > + /*quirks*/ADA_Q_4K > + }, > + { > + /* > * OCZ Agility 3 SSDs > * 4k optimised & trim only works in 4k requests + 4k aligned > */ > -- > 1.8.1.5 > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.