Date: Tue, 30 Mar 2004 14:37:00 +0200 (CEST) From: Lukas Ertl <le@FreeBSD.org> To: Joao Carlos Mendes Luis <jonny@faperj.br> Cc: jonny@jonny.eng.br Subject: Re: Serious bug in vinum? Message-ID: <20040330143257.C72259@pcle2.cc.univie.ac.at> In-Reply-To: <20040326222853.GA93269@zeus.faperj.br> References: <20040326222853.GA93269@zeus.faperj.br>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 26 Mar 2004, Joao Carlos Mendes Luis wrote:
> I think this should be like:
>
> if (plex->state > plex_corrupt) { /* something accessible, */
>
> Or, in other words, volume state is up only if plex state is degraded
> or better.
You are right, this is a bug, but the solution is not that easy. There
are scenarios where - even when a striped plex has failed - the volume
itself plus all its data is valid, so simply setting it down isn't the
'right' way to do it.
The correct solution, of course, is to check if the data is valid before
changing the volume state, but turn might turn out to be a very complex
check.
cheers,
le
--
Lukas Ertl http://mailbox.univie.ac.at/~le/
le@FreeBSD.org http://people.freebsd.org/~le/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040330143257.C72259>